Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub: remove redundant home_is_set check #26770

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Sub: remove redundant home_is_set check #26770

merged 1 commit into from
Apr 11, 2024

Conversation

peterbarker
Copy link
Contributor

this is already guaranteed to be the case

Expand the diff upwards you can see the if is already checking the return from this function call

@peterbarker
Sub: remove redundant home_is_set check
83003e4 
this is already guaranteed to be the case
rmackay9
rmackay9 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and this makes it consistent with Copter and Blimp.

@Williangalvani Williangalvani merged commit 860498d into ArduPilot:master Apr 11, 2024
56 checks passed
@peterbarker peterbarker deleted the pr/sub-redundant-check branch April 14, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Williangalvani Williangalvani Williangalvani approved these changes

@rmackay9 rmackay9 rmackay9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbarker @rmackay9 @Williangalvani