Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waf: support python 3.12 #26889

Merged
merged 3 commits into from
May 8, 2024
Merged

waf: support python 3.12 #26889

merged 3 commits into from
May 8, 2024

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Apr 26, 2024

depends on:

note the waf PR will require a force push as it rebases on upstream 2.0.27

tested on ubuntu 24.04

@tridge tridge force-pushed the pr-python-3.12 branch 4 times, most recently from 3f98daa to fb5e9eb Compare April 30, 2024 04:06
@tridge tridge force-pushed the pr-python-3.12 branch from fb5e9eb to 8178645 Compare May 7, 2024 06:28
@tridge tridge force-pushed the pr-python-3.12 branch 2 times, most recently from f93f484 to 3acb7f4 Compare May 7, 2024 09:04
@tridge tridge merged commit c097cd7 into ArduPilot:master May 8, 2024
91 checks passed
@jonhoo
Copy link

jonhoo commented Aug 20, 2024

Was it intentional that this wasn't included in the recently-released Plane-4.5.5?

@rmackay9
Copy link
Contributor

Hi @jonhoo,

We get this question a lot so perhaps we should extend our Copter Release Procedures wiki page so we can just point users at the answer each time.

In any case, every PR that is merge to master is not automatically backported to the stable releases. Only those that have their "Project" set to something like "4.5 Backports" are considered for back porting.

Every PR merged to master will be part of the next major release though. E.g. 4.6.0

In any case, I've just marked this one for Backporting so it will at least be considered.

Thanks for using AP!

@jonhoo
Copy link

jonhoo commented Aug 20, 2024

Thanks for the quick reply! I actually did find that page and looked through it for a clue as to why this happened. I failed to find a Project for Plane-4.5 (I did find the 4.5 backports list though), which threw me off. I also didn't find a reason for why the MR which landed in May wouldn't be included in the very recent 4.5.5 release which I (perhaps incorrectly) assumed would be forked after master and thus shouldn't need to be backported (I now suspect the answer is that I should have looked at when 4.5 was forked from master). And then I also didn't find a way to suggest that something be backported given the 4.5 backport list had already been created. So I figured it'd at that point probably be best to just ask 😅

@jonhoo
Copy link

jonhoo commented Aug 20, 2024

Oh, and thank you for adding it! Without it, Ardupilot doesn't build for Python 3.12, so would be a welcome addition :)

@jonhoo
Copy link

jonhoo commented Aug 20, 2024

Would it be useful for me to open a PR with the backport to the Plane-4.5 branch, or not so much?

jonhoo pushed a commit to jonhoo/ardupilot that referenced this pull request Aug 20, 2024
@rmackay9
Copy link
Contributor

Hi @jonhoo,

Thanks for that and yes, your understanding is totally correct above. A backport PR always helps especially when the PR can't be cherry-picked into the branch without merge conflicts

jonhoo pushed a commit to jonhoo/ardupilot that referenced this pull request Aug 21, 2024
jonhoo pushed a commit to jonhoo/ardupilot that referenced this pull request Aug 21, 2024
jonhoo pushed a commit to jonhoo/ardupilot that referenced this pull request Aug 21, 2024
@jonhoo
Copy link

jonhoo commented Aug 21, 2024

Done in #27889 👍
Worth also backporting this to 4.3 and 4.4?

jonhoo pushed a commit to jonhoo/ardupilot that referenced this pull request Aug 21, 2024
jonhoo pushed a commit to jonhoo/ardupilot that referenced this pull request Aug 21, 2024
@rmackay9
Copy link
Contributor

this has been included in Copter-4.5.7-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.5.7-beta1
Development

Successfully merging this pull request may close these issues.

5 participants