-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waf: support python 3.12 #26889
waf: support python 3.12 #26889
Conversation
3f98daa
to
fb5e9eb
Compare
this fixes python 3.12 support
f93f484
to
3acb7f4
Compare
Was it intentional that this wasn't included in the recently-released Plane-4.5.5? |
Hi @jonhoo, We get this question a lot so perhaps we should extend our Copter Release Procedures wiki page so we can just point users at the answer each time. In any case, every PR that is merge to master is not automatically backported to the stable releases. Only those that have their "Project" set to something like "4.5 Backports" are considered for back porting. Every PR merged to master will be part of the next major release though. E.g. 4.6.0 In any case, I've just marked this one for Backporting so it will at least be considered. Thanks for using AP! |
Thanks for the quick reply! I actually did find that page and looked through it for a clue as to why this happened. I failed to find a Project for Plane-4.5 (I did find the 4.5 backports list though), which threw me off. I also didn't find a reason for why the MR which landed in May wouldn't be included in the very recent 4.5.5 release which I (perhaps incorrectly) assumed would be forked after |
Oh, and thank you for adding it! Without it, Ardupilot doesn't build for Python 3.12, so would be a welcome addition :) |
Would it be useful for me to open a PR with the backport to the Plane-4.5 branch, or not so much? |
Backport of ArduPilot#26889.
Hi @jonhoo, Thanks for that and yes, your understanding is totally correct above. A backport PR always helps especially when the PR can't be cherry-picked into the branch without merge conflicts |
Backport of ArduPilot#26889.
Backport of ArduPilot#26889.
Done in #27889 👍 |
this has been included in Copter-4.5.7-beta1 |
depends on:
note the waf PR will require a force push as it rebases on upstream 2.0.27
tested on ubuntu 24.04