-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane: backport support for Python 3.12 to 4.5 #27889
Conversation
e6a10d3
to
e4fe5b4
Compare
Apologies for the force pushes – my local |
This is a single commit - was this really a single commit into master? That would be contrary to our usual standards as it's got a mavlink commit in there. We need to know what else went into that mavlink branch as part of that new submodule reference. We might need to reference a new commit in there if we are uncomfortable with other stuff implied by that mavlink submodule update |
The CI failure seems pretty weird (and maybe unrelated?):
|
Now, it is true that for the backport, this ends up picking up a few extra commits to mavlink, but a cursory look at them suggests they'd be okay to bring in here (i.e., not worth doing a cherry-pick): ArduPilot/mavlink@1e04d8b...2825252d6d13eb347520f028b3c580ab29bd78e5^ |
this fixes python 3.12 support
e4fe5b4
to
d2e9e67
Compare
Okay, I have now cherry-picked the individual commits instead. |
Is it worth also backporting this to 4.3 and 4.4? |
Hi @jonhoo, Thanks for this. I don't think it's worth creating a 4.3 or 4.4 backport because we don't plan to do any more releases for those version. |
This is included in Copter-4.5.7-beta1 |
Backport of #26889.