-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: opt TextControl component to 40px default size in Gutenberg #41127
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
@simison I update the select fields as well in the last push. |
…utenberg (#41127) * Forms: settings, opt-in for default 40px size in gutenberg * changelog * Update the select field as well to use the new size. So that it looks aligned. --------- Co-authored-by: Enej Bajgoric <[email protected]>
Fixes #41128
Addresses warning:
Note that there are unrelated spacing issues in fields that I'll fix separately.
Proposed changes:
Before
After
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: