Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: opt TextControl component to 40px default size in Gutenberg #41127

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Forms: opt TextControl component to 40px default size in Gutenberg #41127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b0378b
Forms: settings, opt-in for default 40px size in gutenberg
simison Jan 16, 2025
97957c5
changelog
simison Jan 16, 2025
340534c
Update the select field as well to use the new size. So that it looks…
enejb Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/update-forms-textcontrol-40px-default
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: changed

Forms: settings, opt-in for default 40px size in gutenberg
2 changes: 2 additions & 0 deletions ...ts/packages/forms/src/blocks/contact-form/components/jetpack-email-connection-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ const JetpackEmailConnectionSettings = ( {
'jetpack-forms'
) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>

<HelpMessage isError id={ `contact-form-${ instanceId }-email-error` }>
Expand All @@ -122,6 +123,7 @@ const JetpackEmailConnectionSettings = ( {
placeholder={ __( 'Enter a subject', 'jetpack-forms' ) }
onChange={ newSubject => setAttributes( { subject: newSubject } ) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
</>
);
Expand Down
1 change: 1 addition & 0 deletions projects/packages/forms/src/blocks/contact-form/components/jetpack-field-consent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ const JetpackFieldConsent = ( {
] }
onChange={ value => setAttributes( { consentType: value } ) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
</BaseControl>
</PanelBody>
Expand Down
2 changes: 2 additions & 0 deletions projects/packages/forms/src/blocks/contact-form/components/jetpack-field-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ const JetpackFieldControls = ( {
'jetpack-forms'
) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
),
<JetpackFieldWidth key="width" setAttributes={ setAttributes } width={ width } />,
Expand Down Expand Up @@ -274,6 +275,7 @@ const JetpackFieldControls = ( {
'jetpack-forms'
) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
</InspectorAdvancedControls>
</>
Expand Down
1 change: 1 addition & 0 deletions projects/packages/forms/src/blocks/contact-form/components/jetpack-field-datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ const JetpackDatePicker = props => {
'jetpack-forms'
) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
),
},
Expand Down
1 change: 1 addition & 0 deletions ...act-form/components/jetpack-salesforce-lead-form/jetpack-salesforce-lead-form-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export default ( { salesforceData, setAttributes, instanceId } ) => {
onChange={ setOrganizationId }
help={ __( 'Enter the Salesforce organization ID to send Leads to.', 'jetpack-forms' ) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
{ organizationIdError && (
<HelpMessage isError id={ `contact-form-${ instanceId }-email-error` }>
Expand Down
2 changes: 2 additions & 0 deletions projects/packages/forms/src/blocks/contact-form/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export const JetpackContactFormEdit = forwardRef(
] }
onChange={ newMessage => setAttributes( { customThankyou: newMessage } ) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>

{ 'redirect' !== customThankyou && (
Expand All @@ -184,6 +185,7 @@ export const JetpackContactFormEdit = forwardRef(
placeholder={ __( 'Your message has been sent', 'jetpack-forms' ) }
onChange={ newHeading => setAttributes( { customThankyouHeading: newHeading } ) }
__nextHasNoMarginBottom={ true }
__next40pxDefaultSize={ true }
/>
) }

Expand Down
Loading