fix: enable kubelet serving certificate rotation #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallaxes
added
area/bootstrap
| @@ -116,6 +116,7 @@ HTTPS_PROXY_URLS="{{.HTTPSProxyURLs}}" | |||
| NO_PROXY_URLS="{{.NoProxyURLs}}" | |||
| ENABLE_TLS_BOOTSTRAPPING="{{.TLSBootstrappingEnabled}}" | |||
| ENABLE_SECURE_TLS_BOOTSTRAPPING="{{.SecureTLSBootstrappingEnabled}}" | |||
| ENABLE_KUBELET_SERVING_CERTIFICATE_ROTATION="true" | |||
There was a problem hiding this comment.
not currently safe to set to true in public cloud regions
There was a problem hiding this comment.
once it is safe to do so in any public region, this should only be set to true iff:
- MC is on k8s 1.27+
- MC has k8s RBAC enabled
There was a problem hiding this comment.
it's already correct, but please also be sure to maintain these settings for --tls-cert-file + --tls-private-key-file:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configures
ENABLE_KUBELET_SERVING_CERTIFICATE_ROTATION=truein bootstrap (should fix bootstrap of202501.12.0VHD image version).How was this change tested?
Does this change impact docs?
Release Note