Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable kubelet serving certificate rotation #651

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: enable kubelet serving certificate rotation #651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/providers/imagefamily/bootstrap/cse_cmd.sh.gtpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ HTTPS_PROXY_URLS="{{.HTTPSProxyURLs}}"
NO_PROXY_URLS="{{.NoProxyURLs}}"
ENABLE_TLS_BOOTSTRAPPING="{{.TLSBootstrappingEnabled}}"
ENABLE_SECURE_TLS_BOOTSTRAPPING="{{.SecureTLSBootstrappingEnabled}}"
ENABLE_KUBELET_SERVING_CERTIFICATE_ROTATION="true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not currently safe to set to true in public cloud regions

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once it is safe to do so in any public region, this should only be set to true iff:

  • MC is on k8s 1.27+
  • MC has k8s RBAC enabled

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already correct, but please also be sure to maintain these settings for --tls-cert-file + --tls-private-key-file:

https://github.com/Azure/karpenter-provider-azure/blob/main/pkg/providers/imagefamily/bootstrap/aksbootstrap.go#L269-L271

DHCPV6_SERVICE_FILEPATH="{{.DHCPv6ServiceFilepath}}"
DHCPV6_CONFIG_FILEPATH="{{.DHCPv6ConfigFilepath}}"
THP_ENABLED="{{.THPEnabled}}"
Expand Down
Loading