Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds version macros for segmetrics tool #88

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

kostrykin
Copy link
Member

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the galaxy-image-analysis repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)
  • - Tools added/updated by this PR (if any) comply with the Naming and Annotation Conventions for Tools in the Image Community in Galaxy (or please explain why they do not)

@kostrykin kostrykin changed the title adds zenodo citation to segmetrics tool adds version macros for segmetrics tool Nov 11, 2023
<description>with SegMetrics</description>
<macros>
<token name="@TOOL_VERSION@">1.4</token>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not promise you that 1.4+galaxy is higher than 1.4.0-1 ... we risk it or try that out before. Need to find the snippet how Pyhton and Galaxy calculates the version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no changes besides the versioning scheme, we might as well remove the 1.4.0-1 version from toolshed, I guess?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not remove stuff from the TS - reproducibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe version 1.4.0-1 can then be marked as deprecated or hidden?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this we can do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kannst du mir das mal alles auf eine ToDo liste schreiben. Ich muss diese ganzen hidden tools dann mal in einem Rutsch machen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#93 :)

@bgruening bgruening merged commit 1db841f into BMCV:master Nov 14, 2023
10 checks passed
@kostrykin kostrykin deleted the segmetrics branch November 14, 2023 16:56
kostrykin added a commit to kostrykin/usegalaxy-eu-tools that referenced this pull request Nov 14, 2023
bgruening pushed a commit to usegalaxy-eu/usegalaxy-eu-tools that referenced this pull request Nov 16, 2023
* adds latest revision of segmetrics

xref BMCV/galaxy-image-analysis#88

* adds latest revisions of segmetrics and superdsm

Adds latest updates from BMCV/galaxy-image-analysis#94

* adds bioformats2raw tool

xref BMCV/galaxy-image-analysis#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants