Port openerTabId

[laniakea64]

Tag #484 (comment) . Waterfox pretending to be Firefox 57 on AMO allows installing extensions that depend on this API being available, e.g. Violentmonkey.

I'm using these patches in my daily-use Waterfox build for several days now, haven't noticed any issues.

[laniakea64]

Hi @MrAlex94 I'm not sure for how much longer I'll have time to deal with pull requests, and the patches I have that fix the noreferrer issue don't apply without the patches in this PR. These patches continue to work for me in Waterfox 56.2.7.1. Could you please review and merge this PR soon? Thanks.

[grahamperrin]

Preparing to alpha test on FreeBSD-CURRENT,

root@momh167-gjp4-8570p:/usr/local/poudriere/ports/default # make makesum -C www/waterfox
=> grahamperrin-Waterfox-56.2.7.2_GH0.tar.gz doesn't seem to exist in /usr/local/poudriere/ports/default/distfiles/.
=> Attempting to fetch https://codeload.github.com/grahamperrin/Waterfox/tar.gz/56.2.7.2?dummy=/grahamperrin-Waterfox-56.2.7.2_GH0.tar.gz
fetch: https://codeload.github.com/grahamperrin/Waterfox/tar.gz/56.2.7.2?dummy=/grahamperrin-Waterfox-56.2.7.2_GH0.tar.gz: size of remote file is not known
grahamperrin-Waterfox-56.2.7.2_GH0.tar.gz              377 MB 4813 kBps 01m21s
root@momh167-gjp4-8570p:/usr/local/poudriere/ports/default # clear
root@momh167-gjp4-8570p:/usr/local/poudriere/ports/default # date ; uname -v
Sun Feb  3 20:23:31 GMT 2019
FreeBSD 13.0-CURRENT r343308 GENERIC-NODEBUG 
root@momh167-gjp4-8570p:/usr/local/poudriere/ports/default # cd www/waterfox
root@momh167-gjp4-8570p:/usr/local/poudriere/ports/default/www/waterfox # make configure

	┌──────────────────────────── waterfox-56.2.7.2 ───────────────────────────────┐
	│ ┌──────────────────────────────────────────────────────────────────────────┐ │  
	│ │+[ ] CANBERRA          Sound theme alerts                                 │ │  
	│ │+[x] DBUS              D-Bus IPC system support                           │ │  
	│ │+[ ] DEBUG             Build with debugging support                       │ │  
	│ │+[x] FFMPEG            FFmpeg support (WMA, AIFF, AC3, APE...)            │ │  
	│ │+[x] GCONF             GConf configuration backend support                │ │  
	│ │+[ ] LIBPROXY          Proxy support via libproxy                         │ │  
	│ │+[x] OPTIMIZED_CFLAGS  Use extra compiler optimizations                   │ │  
	│ │+[ ] PROFILE           Build with profiling support                       │ │  
	│ │+[ ] TEST              Build and/or run tests                             │ │  
	│ │+[ ] WAYLAND           Wayland (graphics) support                         │ │  
	│ │────────────────────────────────── AUDIO ─────────────────────────────────│ │  
	│ │+[x] ALSA              ALSA audio architecture support                    │ │  
	│ │+[x] JACK              JACK audio server support                          │ │  
	│ │+[x] PULSEAUDIO        PulseAudio sound server support                    │ │  
	│ │+[ ] SNDIO             Sndio audio support                                │ │  
	│ └──────────────────────────────────────────────────────────────────────────┘ │  
	├──────────────────────────────────────────────────────────────────────────────┤  
	│                       <  OK  >            <Cancel>                           │  
	└──────────────────────────────────────────────────────────────────────────────┘  

===>   NOTICE:

This port is deprecated; you may wish to reconsider installing it:

Temporary experiment.

It is scheduled to be removed on or after 2018-09-27.

===>   waterfox-56.2.7.2 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by waterfox-56.2.7.2 for building
===>  Extracting for waterfox-56.2.7.2
=> SHA256 Checksum OK for grahamperrin-Waterfox-56.2.7.2_GH0.tar.gz.
===>  Patching for waterfox-56.2.7.2
===>  Applying FreeBSD patches for waterfox-56.2.7.2
No such line 7185 in input file, ignoring
No such line 326 in input file, ignoring
No such line 93 in input file, ignoring
No such line 2261 in input file, ignoring
No such line 93 in input file, ignoring
No such line 13586 in input file, ignoring
No such line 878 in input file, ignoring
No such line 1265 in input file, ignoring
No such line 237 in input file, ignoring
No such line 230 in input file, ignoring
No such line 2422 in input file, ignoring
No such line 3942 in input file, ignoring
No such line 1449 in input file, ignoring
No such line 1689 in input file, ignoring
No such line 642 in input file, ignoring
No such line 1459 in input file, ignoring
No such line 5308 in input file, ignoring
No such line 1708 in input file, ignoring
No such line 1513 in input file, ignoring
===>   waterfox-56.2.7.2 depends on package: nspr>=4.16 - found
…

– alpha for me because of the deprecation and currently ignored patch lines. NB the 56.2.7.2 is purely notional (I experimented with a different tag, 56.2.7.2-alpha, couldn't get it to work with the make makesum -C command in my environment).

[laniakea64]

Hi @grahamperrin how is the alpha test going?
Is there any way we can get @MrAlex94 attention on this? Due to this blocking a fix for a privacy issue, this is more urgent than it looks.

[laniakea64]

Sorry, closed in error.

[grahamperrin]

@laniakea64 hi, I did have my custom 56.2.7.2 for a while but (sorry) re: your grahamperrin#3 (comment) I found no time to test it in the ways that you suggested.

(Priorities were necessarily elsewhere. I lost the ability to build Waterfox, resolved at https://github.com/MrAlex94/Waterfox/issues/860#issuecomment-462096242 with a less adventurous build of 56.2.7.1. More generally https://lists.freebsd.org/pipermail/freebsd-current/2019-February/072785.html tackling show-stopping issues that arose from my choice to test a bump to LLVM. Probably some foot-shooting there, I haven't reached a conclusion, might do so this evening.)

Now with an updated OS, I might be able to begin a new build of custom 56.2.7.2, including your patches, this afternoon.

[laniakea64]

Hi, any updates on this?
Is something else needed from my end to get this moving forward?

[grahamperrin]

No observed difficulties with my unofficial https://github.com/grahamperrin/Waterfox/releases/tag/56.2.7.2