Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port openerTabId #3

Merged
merged 4 commits into from
Feb 3, 2019
Merged

Port openerTabId #3

merged 4 commits into from
Feb 3, 2019

Conversation

grahamperrin
Copy link
Owner

@laniakea64
Port 'Bug 1357589: Part 1 - Use the correct default remote type for c…
a913eed 
…ontent-created tabs/windows. r=mconley r=mystor

When creating new windows/tabs from the content process, we currently choose
the default remote type based on the referrer URI, rather than the actual
remote type of the opener. While this generally works, it fails when opening
windows from URLs (particularly in iframes) which are opened in process types
other than their default process type, since the initial about:blank load gets
redirected to a new process before the child process has a chance to load its
actual target URI.

Using the actual remote type of the child opening the window fixes this
problem for URLs which are capable of being loaded into the child's process
type.'
@laniakea64
Port 'Bug 1357589: Part 2 - Test that opening web URLs from extension…
6187285 
… iframes works correctly.'
@laniakea64
Port 'Bug 1238314: Part 1 - Track opener tabs separately from owner a…
fcc9a02 
…nd selected tab.'
@laniakea64
Port 'Bug 1238314: Part 2 - Implement browser.tabs openerTabId functi…
6e82b07 
…onality.'
@grahamperrin grahamperrin merged commit 161dfbb into grahamperrin:master Feb 3, 2019
@grahamperrin
Copy link
Owner Author

@laniakea64 hi, this unofficial fork is now built on FreeBSD-CURRENT, I'll test drive it for maybe a few days. Alpha test, considering what's at BrowserWorks#832 (comment)

I rarely/never use Violentmonkey, can you suggest any other extensions (for Firefox 57.0 or later) that require or benefit from the API?

TIA

@laniakea64
Copy link

laniakea64 commented Feb 4, 2019 •
edited
Loading

can you suggest any other extensions (for Firefox 57.0 or later) that require or benefit from the API?

@grahamperrin grahamperrin mentioned this pull request Feb 13, 2019
Merged
@grahamperrin
Copy link
Owner Author

Custom 56.2.7.2 rebuilt with FreeBSD-CURRENT r344013.

Note to self

  • things such as About Waterfox are not customised

– this build presents itself as 56.2.7.1.

image

@grahamperrin
Copy link
Owner Author

grahamperrin commented Feb 13, 2019 •
edited
Loading

Search by Image on Google

Version 1.6: working.

A handful of lazy tests with the image in the previous comment.

• The extension now respects the user's preference whether or not to open new tabs right after the current one

Not tested.

@grahamperrin
Copy link
Owner Author

Reddit Enhancement Suite

Version 5.12.8

Single Click Opener singleClick

Reference:

Open Background openBackground enabled.

about:config?filter=browser.tabs.insertRelatedAfterCurrent

  • browser.tabs.insertRelatedAfterCurrent temporarily set to false.

Tested:

Result:

  • two background tabs, distanced from the parent
  • after viewing and closing both children, frontmost is an adjacent loaded tab (not the distant parent) – I don't know whether this is proper.

Post-testing:

browser.tabs.insertRelatedAfterCurrent reverted to the default, my preference, true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamperrin @laniakea64