-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry and pipenv install instructions #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a Pipfile updated .gitignore. Need to check some args in pre-commit-config not 100% clear on what is needed.
… a Pipfile updated .gitignore. Need to check some args in pre-commit-config not 100% clear on what is needed.
…glab into poetry_pipenv_install
This was referenced Dec 3, 2022
Draft
jake-aft
changed the title
Poetry and pipenv install
Poetry and pipenv install instructions
Jul 12, 2023
ceteri
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, many thanks @jake-aft !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour
No instructions to install kglab with pipenv or poetry
Issue: Improve installation- #272
New expected behaviour
Instructions to install kglab with pipenv or poetry
Change logs
Instructions to install kglab with pipenv
This is not for building the package or development work on kglab project.
Instructions to install kglab with poetry
This is not for building the package or development work on kglab project.
Readme updated with Instructions to install kglab with pipenv or poetry
Created new directory to test the install envs
Removed and decoupled the Poetry Build changes from the previous PR. These will follow in a future PR