654 gs lineage filter add button to delete current input #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.13.0 (2025-01-21)⚠ BREAKING CHANGES
Features
Code Refactoring |
components/src/preact/lineageFilter/LineageFilterChangedEvent.ts
Outdated
Show resolved
Hide resolved
JonasKellerer
force-pushed
the
660-extract-dropdown-from-text-input-and-location-filter
branch
from
3aefe97 to
70cb363
Compare
Base automatically changed from
660-extract-dropdown-from-text-input-and-location-filter
to
main
January 20, 2025 09:29
JonasKellerer
force-pushed
the
654-gs-lineage-filter-add-button-to-delete-current-input
branch
from
00a9074 to
f3a57f5
Compare
anna-parker
approved these changes
Jan 20, 2025
fengelniederhammer
approved these changes
Jan 20, 2025
|
Just a little commit message nitpick: I usually prefer to have the exact component tag in the message. "lineage filter" seems a little too unspecific to me. That's why I usually write messages that target a single component in the style |
JonasKellerer
force-pushed
the
654-gs-lineage-filter-add-button-to-delete-current-input
branch
from
95bc4e6 to
469f475
Compare
added 2 commits
January 21, 2025 07:58
BREAKING CHANGE: Rename initialValue to value for gs-lineage-filter
JonasKellerer
force-pushed
the
654-gs-lineage-filter-add-button-to-delete-current-input
branch
from
469f475 to
b22b710
Compare
JonasKellerer
deleted the
654-gs-lineage-filter-add-button-to-delete-current-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #654
Summary
Downshift is now used for the lineage filter.
Breaking change: renames initialValue to value to be in line with the generic input element.
Screenshot
The input with delete button
PR Checklist