Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gs-lineage-filter: add button to delete current input #654

Closed
fengelniederhammer opened this issue Jan 14, 2025 · 0 comments · Fixed by #662 or #667
Closed

gs-lineage-filter: add button to delete current input #654

fengelniederhammer opened this issue Jan 14, 2025 · 0 comments · Fixed by #662 or #667
Assignees
@JonasKellerer
Labels
components Regarding the components

Comments

@fengelniederhammer
Copy link
Collaborator

  • Introduce downshift for the autocomplete suggestions
  • Add a button (with a "x") in the input field that deletes the current input

This can be mostly copied from the location filter.
@fengelniederhammer fengelniederhammer added the components Regarding the components label Jan 14, 2025
@fengelniederhammer fengelniederhammer mentioned this issue Jan 14, 2025
Open
@JonasKellerer JonasKellerer self-assigned this Jan 17, 2025
@JonasKellerer JonasKellerer mentioned this issue Jan 17, 2025
Merged
JonasKellerer pushed a commit that referenced this issue Jan 18, 2025
feat(components): use downshift for lineage filter
15a04b9 
Resolves #654
@JonasKellerer JonasKellerer mentioned this issue Jan 18, 2025
Merged
2 tasks
@JonasKellerer JonasKellerer linked a pull request Jan 20, 2025 that will close this issue
654 gs lineage filter add button to delete current input #662
Merged
2 tasks
@github-actions github-actions bot mentioned this issue Jan 20, 2025
Merged
2 tasks
JonasKellerer pushed a commit that referenced this issue Jan 20, 2025
feat(components): use downshift for lineage filter
af7fee1 
Resolves #654
JonasKellerer pushed a commit that referenced this issue Jan 21, 2025
feat(components): use downshift for gs-lineage-filter
46770d8 
Resolves #654
JonasKellerer pushed a commit that referenced this issue Jan 21, 2025
feat(components): gs-lineage-filter: use downshift for selector
e8f1657 
Resolves #654
This was referenced Jan 21, 2025
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasKellerer JonasKellerer

Labels
components Regarding the components
Projects
None yet
Milestone
No milestone
2 participants
@fengelniederhammer @JonasKellerer