-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modifier docs #190
Add modifier docs #190
Conversation
pearce8
commented
Mar 26, 2024
•
edited by slabasan
Loading
edited by slabasan
- (later) modifiers for setting up the resources etc
- Modifiers section - generic definition of a modifier, link to Ramble modifiers
- Caliper modifiers section - generic “Caliper modifier” definition, how to use them, link to Caliper. Followed with a list of specific Caliper modifiers available, where they are applicable (the initial one is platform independent, then its x86 for top-down, and cuda GPUs for the cuda one), and what metrics they collect (so maybe a table with 3 columns we can add to?)
- add table for different caliper modifiers
@slabasan Thanks for the table! I think we can put the modifier name in the left column, so this would be: caliper and would match the string one would put after --modifier="one of the strings in the list above". Do you think this you can make this clear? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple suggestions but don't see any major issues.