System variant: no scheduler #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearce8
commented
Nov 19, 2024
systems/tioga/system.py
Outdated
| @@ -33,8 +33,8 @@ class Tioga(System): | |||
|
|
|||
| def initialize(self): | |||
| super().initialize() | |||
|
|
|||
| self.scheduler = "flux" | |||
| if self.spec.variants["scheduler"][0]=="yes": | |||
There was a problem hiding this comment.
if self.spec.satisfies("schedule=yes"):
becker33
reviewed
Nov 19, 2024
systems/tioga/system.py
Outdated
| @@ -33,8 +33,8 @@ class Tioga(System): | |||
|
|
|||
| def initialize(self): | |||
| super().initialize() | |||
|
|
|||
| self.scheduler = "flux" | |||
| if self.spec.variants["scheduler"][0]=="yes": | |||
There was a problem hiding this comment.
variant("scheduler", values=("flux", "mpi"), default="flux", sticky=True, description="...")
lib/benchpark/system.py
Outdated
| @@ -82,7 +90,7 @@ def initialize(self): | |||
| self.sys_cores_per_node = None | |||
| self.sys_gpus_per_node = None | |||
| self.sys_mem_per_node = None | |||
| self.scheduler = None | |||
| self.scheduler = "mpi" | |||
There was a problem hiding this comment.
Suggested change
| self.scheduler = "mpi" | |
| self.scheduler = self.spec.variants["scheduler"].value |
lib/benchpark/system.py
Outdated
Comment on lines
76
to
81
| variant( | ||
| "scheduler", | ||
| default="yes", | ||
| values=("yes", "none"), | ||
| description="Use the scheduler on the system, or generate scripts without the scheduler commands", | ||
| ) |
There was a problem hiding this comment.
Suggested change
| variant( | |
| "scheduler", | |
| default="yes", | |
| values=("yes", "none"), | |
| description="Use the scheduler on the system, or generate scripts without the scheduler commands", | |
| ) | |
| variant( | |
| "scheduler", | |
| default="mpi", | |
| values=("mpi",), | |
| description="Use the scheduler on the system, or generate scripts without the scheduler commands", | |
| ) |
There was a problem hiding this comment.
I reverted the changes from @dyokelson. @becker33 the dry run now shows the error: the value of the variant is 'mpi' when the concretizer expects 'None'. @scheibelp if you are able to help fix this, please do.
pearce8
force-pushed
the
pearce8-variant-noscheduler
branch
from
3946c3b to
d3c1ce3
Compare
scheibelp
reviewed
Nov 26, 2024
scheibelp
reviewed
Nov 26, 2024
|
Now that Tioga has a new variant, the hash location of the Ramble workspace has changed (sorry - #450 ought to help with this) |
|
As per issue #485, we will do this differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a way to generate run scripts without scheduler instructions, for interactive runs or composing CI runs.
mpi).system init).values=("flux", "mpi")with "flux" being the default option seems brittle.