Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System variant: no scheduler #435

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/benchpark/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import benchpark.paths
from benchpark.directives import ExperimentSystemBase
from benchpark.directives import variant
import benchpark.repo
from benchpark.runtime import RuntimeResources

Expand Down Expand Up @@ -72,6 +73,13 @@ class System(ExperimentSystemBase):
Tuple["benchpark.variant.Variant", "benchpark.spec.ConcreteSystemSpec"],
]

variant(
"scheduler",
default="mpi",
values=("mpi"),
scheibelp marked this conversation as resolved.
Show resolved Hide resolved
description="Base generates scripts without the scheduler commands",
)

def __init__(self, spec):
self.spec: "benchpark.spec.ConcreteSystemSpec" = spec
super().__init__()
Expand All @@ -82,7 +90,7 @@ def initialize(self):
self.sys_cores_per_node = None
self.sys_gpus_per_node = None
self.sys_mem_per_node = None
self.scheduler = None
self.scheduler = self.spec.variants["scheduler"].value
scheibelp marked this conversation as resolved.
Show resolved Hide resolved
self.timeout = "120"
self.queue = None

Expand Down
9 changes: 7 additions & 2 deletions systems/tioga/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,13 @@ class Tioga(System):

def initialize(self):
super().initialize()

self.scheduler = "flux"
variant(
"scheduler",
values=("flux", "mpi"),
default="flux",
sticky=True,
description="Scheduler to use on the system",
)
self.sys_cores_per_node = "64"
self.sys_gpus_per_node = "4"

Expand Down
Loading