-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features/branson #462
base: develop
Are you sure you want to change the base?
features/branson #462
Conversation
repo/branson/package.py
Outdated
cflags = " ".join(self.compiler.flags['cflags']) if 'cflags' in self.compiler.flags else "" | ||
cxxflags = " ".join(self.compiler.flags['cxxflags']) if 'cxxflags' in self.compiler.flags else "" | ||
|
||
args.append("-DCMAKE_C_FLAGS={} -I{}/src/random123/features".format(cflags, self.stage.source_path)) | ||
args.append("-DCMAKE_CXX_FLAGS={} -I{}/src/random123/features".format(cxxflags, self.stage.source_path)) | ||
args.append(f"-DBUILD_TESTING=OFF") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearce8 This is just a temporary fix for lassen. Need to work with the branson team to fix build issues on that system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look at the RNG package again and see if an update fixes this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a dry run.
Description
Building and running on ruby/dane/tioga/lassen. However, the code calls exit().
@alexrlongne This is the PR we are trying to work through.
Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): FIXME:Add list of relevant issues.
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)