Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features/branson #462

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

features/branson #462

wants to merge 30 commits into from

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Dec 1, 2024

Description

Building and running on ruby/dane/tioga/lassen. However, the code calls exit().

@alexrlongne This is the PR we are trying to work through.

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added the application New or modified application label Dec 1, 2024
Comment on lines 71 to 76
cflags = " ".join(self.compiler.flags['cflags']) if 'cflags' in self.compiler.flags else ""
cxxflags = " ".join(self.compiler.flags['cxxflags']) if 'cxxflags' in self.compiler.flags else ""

args.append("-DCMAKE_C_FLAGS={} -I{}/src/random123/features".format(cflags, self.stage.source_path))
args.append("-DCMAKE_CXX_FLAGS={} -I{}/src/random123/features".format(cxxflags, self.stage.source_path))
args.append(f"-DBUILD_TESTING=OFF")
Copy link
Collaborator Author

@rfhaque rfhaque Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 This is just a temporary fix for lassen. Need to work with the branson team to fix build issues on that system.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at the RNG package again and see if an update fixes this.

@github-actions github-actions bot added the experiment New or modified experiment label Dec 2, 2024
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a dry run.

@slabasan slabasan marked this pull request as draft December 12, 2024 04:38
@slabasan slabasan marked this pull request as ready for review December 18, 2024 17:38
@pearce8 pearce8 requested review from scheibelp and removed request for august-knox January 13, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants