-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features/branson #462
Open
rfhaque
wants to merge
30
commits into
develop
Choose a base branch
from
features/branson
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
features/branson #462
Changes from 4 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ec5bd68
branson fix for lassen
31fb7d0
branson experiment fixes
e55474b
Branson experiment.py
3a9d12b
lint
d6a2140
Merge remote-tracking branch 'origin/develop' into features/branson
9eceb18
Merge branch 'develop' into features/branson
rfhaque a5bfa33
Merge branch 'develop' into features/branson
slabasan 57d725b
Merge remote-tracking branch 'origin/develop' into features/branson
249120f
Merge remote-tracking branch 'origin/develop' into features/branson
1d20884
Merge remote-tracking branch 'origin/develop' into features/branson
8e232cf
branson hip cuda implementation
03f28fd
Fix input file params
f1d763f
lint
1783331
venado system specs
rfhaque 2a261f7
Fix NVCC flags
rfhaque 6d0a753
Merge remote-tracking branch 'origin/develop' into systems/venado
752bae8
Fix caliper version
e708c94
Add patches
b6c342d
Fix caliper, slurm issues
rfhaque 4405a94
Merge remote-tracking branch 'origin/develop' into features/branson
rfhaque 49b3fb1
Merge branch 'systems/venado' into features/branson
rfhaque c5bd894
Merge remote-tracking branch 'origin/develop' into features/branson
41295fc
Fix Cmake flags
8a4e9bd
Merge branch 'features/branson' of github.com:LLNL/benchpark into fea…
rfhaque 682c049
Fixes
rfhaque cb8a309
Remove saxpy
d4d2f12
lint, license
eb64782
Pull from venado specs
f6cdf49
venado specs
1084379
gtl
rfhaque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
# Copyright 2023 Lawrence Livermore National Security, LLC and other | ||
# Benchpark Project Developers. See the top-level COPYRIGHT file for details. | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
from benchpark.error import BenchparkError | ||
from benchpark.directives import variant | ||
from benchpark.experiment import Experiment | ||
from benchpark.scaling import StrongScaling | ||
from benchpark.scaling import WeakScaling | ||
from benchpark.expr.builtin.caliper import Caliper | ||
|
||
|
||
class Branson( | ||
Experiment, | ||
StrongScaling, | ||
WeakScaling, | ||
Caliper, | ||
): | ||
variant( | ||
"workload", | ||
default="branson", | ||
description="workload name", | ||
) | ||
|
||
variant( | ||
"version", | ||
default="develop", | ||
description="app version", | ||
) | ||
|
||
def compute_applications_section(self): | ||
# TODO: Replace with conflicts clause | ||
scaling_modes = { | ||
"strong": self.spec.satisfies("+strong"), | ||
"weak": self.spec.satisfies("+weak"), | ||
"single_node": self.spec.satisfies("+single_node"), | ||
} | ||
|
||
scaling_mode_enabled = [key for key, value in scaling_modes.items() if value] | ||
if len(scaling_mode_enabled) != 1: | ||
raise BenchparkError( | ||
f"Only one type of scaling per experiment is allowed for application package {self.name}" | ||
) | ||
|
||
# Number of processes in each dimension | ||
num_nodes = {"n_nodes": 1} | ||
|
||
# Per-process size (in zones) in each dimension | ||
num_particles = {"num_particles": 850000000} | ||
|
||
if self.spec.satisfies("+single_node"): | ||
for pk, pv in num_nodes.items(): | ||
self.add_experiment_variable(pk, pv, True) | ||
for nk, nv in num_particles.items(): | ||
self.add_experiment_variable(nk, nv, True) | ||
elif self.spec.satisfies("+strong"): | ||
scaled_variables = self.generate_strong_scaling_params( | ||
{tuple(num_nodes.keys()): list(num_nodes.values())}, | ||
int(self.spec.variants["scaling-factor"][0]), | ||
int(self.spec.variants["scaling-iterations"][0]), | ||
) | ||
for pk, pv in scaled_variables.items(): | ||
self.add_experiment_variable(pk, pv, True) | ||
for nk, nv in num_particles.items(): | ||
self.add_experiment_variable(nk, nv, True) | ||
elif self.spec.satisfies("+weak"): | ||
scaled_variables = self.generate_weak_scaling_params( | ||
{tuple(num_nodes.keys()): list(num_nodes.values())}, | ||
{tuple(num_particles.keys()): list(num_particles.values())}, | ||
int(self.spec.variants["scaling-factor"][0]), | ||
int(self.spec.variants["scaling-iterations"][0]), | ||
) | ||
for k, v in scaled_variables.items(): | ||
self.add_experiment_variable(k, v, True) | ||
|
||
self.add_experiment_variable("n_ranks", "{n_nodes}*{sys_cores_per_node}", True) | ||
|
||
def compute_spack_section(self): | ||
# get package version | ||
app_version = self.spec.variants["version"][0] | ||
|
||
# get system config options | ||
# TODO: Get compiler/mpi/package handles directly from system.py | ||
system_specs = {} | ||
system_specs["compiler"] = "default-compiler" | ||
system_specs["mpi"] = "default-mpi" | ||
# if self.spec.satisfies("+cuda"): | ||
# system_specs["cuda_version"] = "{default_cuda_version}" | ||
# system_specs["cuda_arch"] = "{cuda_arch}" | ||
# system_specs["blas"] = "cublas-cuda" | ||
# if self.spec.satisfies("+rocm"): | ||
# system_specs["rocm_arch"] = "{rocm_arch}" | ||
# system_specs["blas"] = "blas-rocm" | ||
|
||
# set package spack specs | ||
self.add_spack_spec(system_specs["mpi"]) | ||
|
||
self.add_spack_spec( | ||
self.name, [f"branson@{app_version}", system_specs["compiler"]] | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
ramble: | ||
applications: | ||
branson: | ||
workloads: | ||
branson: | ||
experiments: | ||
branson_branson_weak_scaling_caliper_time_mpi_{n_nodes}_{num_particles}_{n_ranks}: | ||
exclude: {} | ||
matrix: [] | ||
variables: | ||
n_nodes: | ||
- 1 | ||
- 2 | ||
- 4 | ||
- 8 | ||
n_ranks: '{n_nodes}*{sys_cores_per_node}' | ||
num_particles: | ||
- 850000000 | ||
- 1700000000 | ||
- 3400000000 | ||
- 6800000000 | ||
variants: | ||
package_manager: spack | ||
zips: {} | ||
config: | ||
deprecated: true | ||
spack_flags: | ||
concretize: -U -f | ||
install: --add --keep-stage | ||
include: | ||
- ./configs | ||
modifiers: | ||
- name: allocation | ||
- mode: mpi | ||
name: caliper | ||
- mode: time | ||
name: caliper | ||
software: | ||
environments: | ||
branson: | ||
packages: | ||
- caliper | ||
- default-mpi | ||
- branson | ||
packages: | ||
branson: | ||
compiler: default-compiler | ||
pkg_spec: branson@develop+caliper | ||
caliper: | ||
compiler: default-compiler | ||
pkg_spec: caliper@master+adiak+mpi~libunwind~libdw~papi |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pearce8 This is just a temporary fix for lassen. Need to work with the branson team to fix build issues on that system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look at the RNG package again and see if an update fixes this.