Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slices end index is exclusive #134

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: slices end index is exclusive #134

merged 1 commit into from
Jan 20, 2025
+4 −4

Conversation

paoun-ledger
Copy link
Contributor

Slices end index is exclusive since that spec modification:

#83

It's also exclusive in SignerSDK and in the device, so that descriptor should be updated accordingly

@paoun-ledger paoun-ledger requested a review from a team as a code owner January 20, 2025 09:09
@ledger-wiz-cspm-secret-detection
Copy link

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 1 Low
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions github-actions bot added the descriptors Changes to clear signing descriptors label Jan 20, 2025
@paoun-ledger paoun-ledger merged commit 011dd88 into master Jan 20, 2025
5 checks passed
@paoun-ledger paoun-ledger deleted the fix-uniswap-slices branch January 20, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamier fsamier fsamier approved these changes

Assignees
No one assigned
Labels
descriptors Changes to clear signing descriptors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paoun-ledger @fsamier