Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slices end index is exclusive #134

Merged
merged 1 commit into from
Jan 20, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions registry/uniswap/calldata-UniswapV3Router02.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check warning on line 1 in registry/uniswap/calldata-UniswapV3Router02.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field

No display field is defined for path `#.params.path` in function 0x09b81346. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/uniswap/calldata-UniswapV3Router02.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field

No display field is defined for path `#.params.path` in function 0xb858183f. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/uniswap/calldata-UniswapV3Router02.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field

No display field is defined for path `#.params.sqrtPriceLimitX96` in function 0x04e45aaf. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/uniswap/calldata-UniswapV3Router02.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field

No display field is defined for path `#.params.sqrtPriceLimitX96` in function 0x5023b4df. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/uniswap/calldata-UniswapV3Router02.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field

No display field is defined for path `#.to` in function 0x42712a67. If intentionally excluded, please add it to `excluded` list to avoid this warning.

Check warning on line 1 in registry/uniswap/calldata-UniswapV3Router02.json

View workflow job for this annotation

GitHub Actions / 🔎 validate descriptors

Missing Display field

No display field is defined for path `#.to` in function 0x472b43f3. If intentionally excluded, please add it to `excluded` list to avoid this warning.
"$schema": "../../specs/erc7730-v1.schema.json",
"context": {
"$id": "Uniswap v3 Router 2",
Expand All @@ -21,13 +21,13 @@
"path": "params.amountIn",
"label": "Amount to Send",
"format": "tokenAmount",
"params": { "tokenPath": "params.path.[0:19]" }
"params": { "tokenPath": "params.path.[0:20]" }
},
{
"path": "params.amountOutMinimum",
"label": "Minimum amount to Receive",
"format": "tokenAmount",
"params": { "tokenPath": "params.path.[-20:-1]" }
"params": { "tokenPath": "params.path.[-20:]" }
},
{
"path": "params.recipient",
Expand Down Expand Up @@ -67,13 +67,13 @@
"path": "params.amountInMaximum",
"label": "Maximum Amount to Send",
"format": "tokenAmount",
"params": { "tokenPath": "params.path.[0:19]" }
"params": { "tokenPath": "params.path.[0:20]" }
},
{
"path": "params.amountOut",
"label": "Amount to Receive",
"format": "tokenAmount",
"params": { "tokenPath": "params.path.[-20:-1]" }
"params": { "tokenPath": "params.path.[-20:]" }
},
{
"path": "params.recipient",
Expand Down