Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jca/relocation obsidian way #128

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Jca/relocation obsidian way #128

merged 3 commits into from
Feb 5, 2024

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Feb 1, 2024

No description provided.

@yogh333 yogh333 force-pushed the jca/relocation_obsidian_way branch from 6920bf7 to a630c93 Compare February 2, 2024 09:41
@yogh333 yogh333 marked this pull request as ready for review February 2, 2024 09:44
@yogh333 yogh333 requested a review from yhql February 2, 2024 09:44
@yogh333 yogh333 requested a review from yhql February 5, 2024 09:55
yhql
yhql approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@yhql yhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the bash script, but we can fix that later :)

@yogh333 yogh333 merged commit 65d40ef into master Feb 5, 2024
22 checks passed
@yogh333 yogh333 deleted the jca/relocation_obsidian_way branch February 5, 2024 10:13
@yogh333 yogh333 mentioned this pull request Feb 21, 2024
Merged
@yogh333 yogh333 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhql yhql yhql approved these changes

@xchapron-ledger xchapron-ledger Awaiting requested review from xchapron-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogh333 @yhql @xchapron-ledger