Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Speculos][Playwright][Detox] Fixing scheduled run broadcast #8887

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Jan 14, 2025

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Speculos tests broadcast

📝 Description

Broadcast for scheduled Speculos runs is broken because github.event.schedule.cron seems not available in composite actions. Passing schedule_cron as input to set-broadcast action to fix this.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:50am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:50am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:50am

@live-github-bot live-github-bot bot added tools Has changes in tools automation CI/CD stuff labels Jan 14, 2025
@abdurrahman-ledger abdurrahman-ledger requested a review from a team January 14, 2025 06:36
@abdurrahman-ledger abdurrahman-ledger merged commit a113283 into develop Jan 14, 2025
34 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_429_fix_speculos_broadcast branch January 14, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants