Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Speculos][Playwright][Detox] Fixing scheduled run broadcast #8887

Merged
merged 3 commits into from
Jan 14, 2025
Merged

[Speculos][Playwright][Detox] Fixing scheduled run broadcast #8887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c2fce5
ci: pass schedule_cron as input to set-broadcast action
abdurrahman-ledger Jan 14, 2025
f3958b5
ci: test action modification
abdurrahman-ledger Jan 14, 2025
083fb26
Revert "ci: test action modification"
abdurrahman-ledger Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test-mobile-e2e-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ jobs:
uses: LedgerHQ/ledger-live/tools/actions/composites/setup-e2e-broadcast@develop
with:
enable_broadcast: ${{ inputs.enable_broadcast }}
schedule_cron: ${{ github.event.schedule.cron }}
- name: Run Android Tests
id: detox
run: pnpm mobile e2e:ci -p android -t $([[ "$INPUT_SPECULOS" == "true" ]] && printf %s '--speculos') --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-ui-e2e-only-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ jobs:
uses: LedgerHQ/ledger-live/tools/actions/composites/setup-e2e-broadcast@develop
with:
enable_broadcast: ${{ inputs.enable_broadcast }}
schedule_cron: ${{ github.event.schedule.cron }}

- name: Run playwright tests [Linux => xvfb-run]
id: tests
Expand Down
6 changes: 5 additions & 1 deletion tools/actions/composites/setup-e2e-broadcast/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ inputs:
description: "Enable transaction broadcast"
required: false
default: "false"
schedule_cron:
description: "Cron expression for scheduled runs"
required: false
default: ""

runs:
using: composite
Expand All @@ -13,7 +17,7 @@ runs:
id: set-broadcast
shell: bash
run: |
if [[ "${{ inputs.enable_broadcast }}" == "true" || ( "${{ github.event_name }}" == "schedule" && "${{ github.event.schedule.cron }}" == "0 5 * * 1" ) ]]; then
if [[ "${{ inputs.enable_broadcast }}" == "true" || ( "${{ github.event_name }}" == "schedule" && "${{ inputs.schedule_cron }}" == "0 5 * * 1" ) ]]; then
echo "DISABLE_TRANSACTION_BROADCAST=0" >> $GITHUB_ENV
else
echo "DISABLE_TRANSACTION_BROADCAST=1" >> $GITHUB_ENV
Expand Down