Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix: generate kodi_id for cases where a list item has no DBID #22

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 30, 2023

Description

Video addons do not have a DBID. This PR modifies Themerr's behavior to use a generated kodi_id instead of using the DBID.

Todo:

  • Update unit tests

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (4d576bd) 82.13% compared to head (674f114) 84.56%.

Files Patch % Lines
src/themerr/gui.py 63.88% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   82.13%   84.56%   +2.43%     
==========================================
  Files          11       11              
  Lines         319      324       +5     
==========================================
+ Hits          262      274      +12     
+ Misses         57       50       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 30, 2023 14:01
@ReenigneArcher ReenigneArcher merged commit ee0881f into master Dec 30, 2023
12 of 13 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-generate-kodi_id branch December 30, 2023 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not working with Fen and Artic Fuse
1 participant