Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non-relative file paths #897

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented Dec 6, 2024

If relative_to method fails, the exception returns the ValueError caused by this failure instead of the actual exception. This fix ensures that the exception is handled properly.

  • add tests

If relative_to method fails, the exception returns the ValueError caused
by this failure instead of the actual exception. This fix ensures that
the exception is handled properly.
@Pouyanpi Pouyanpi added this to the v0.12.0 milestone Dec 6, 2024
@Pouyanpi Pouyanpi self-assigned this Dec 6, 2024
@Pouyanpi Pouyanpi added bug Something isn't working status: in progress Issues that are currently being worked on. labels Jan 8, 2025
@Pouyanpi Pouyanpi added status: in review and removed status: in progress Issues that are currently being worked on. labels Jan 9, 2025
@Pouyanpi Pouyanpi requested a review from cparisien January 9, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant