fix: handle non-relative file paths

nemoguardrails/actions/action_dispatcher.py

@@ -320,7 +320,10 @@ def _load_actions_from_module(filepath: str):
                             f"Failed to register {obj.action_meta['name']} in action dispatcher due to exception {e}"
                         )
         except Exception as e:
-            relative_filepath = Path(module.__file__).relative_to(Path.cwd())
+            try:
+                relative_filepath = Path(module.__file__).relative_to(Path.cwd())
+            except ValueError:
+                relative_filepath = Path(module.__file__).resolve()
             log.error(
                 f"Failed to register {filename} from {relative_filepath} in action dispatcher due to exception: {e}"
             )

tests/test_action_dispatcher.py

@@ -0,0 +1,133 @@
+# SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import inspect
+import tempfile
+from pathlib import Path
+from unittest.mock import MagicMock
+
+import pytest
+
+from nemoguardrails.actions.action_dispatcher import ActionDispatcher
+
+
+@pytest.fixture
+def temp_module():
+    """Temporary module with actions for testing"""
+
+    with tempfile.TemporaryDirectory() as temp_dir:
+        module_path = Path(temp_dir) / "actions.py"
+        with open(module_path, "w") as f:
+            f.write(
+                """
+import inspect
+
+def action_meta(name):
+    def decorator(func):
+        func.action_meta = {"name": name}
+        return func
+    return decorator
+
+@action_meta("test_action")
+def test_action():
+    return "test"
+
+class TestActionClass:
+    action_meta = {"name": "test_action_class"}
+
+    def run(self):
+        return "test_class"
+"""
+            )
+        yield module_path
+
+
+def test_load_actions_from_module(temp_module):
+    """Test loading actions from a valid and existing module"""
+
+    dispatcher = ActionDispatcher(load_all_actions=False)
+    actions = dispatcher._load_actions_from_module(temp_module)
+
+    assert "test_action" in actions
+    assert "test_action_class" in actions
+    assert callable(actions["test_action"])
+    assert inspect.isclass(actions["test_action_class"])
+
+
+def test_load_actions_from_nonexistent_module():
+    """Test loading actions from a non-existent module"""
+
+    dispatcher = ActionDispatcher(load_all_actions=False)
+    actions = dispatcher._load_actions_from_module("/nonexistent/path/actions.py")
+
+    assert actions == {}
+
+
+def test_load_actions_from_invalid_module():
+    """Test loading actions from a module with invalid code"""
+
+    # before the fix following exception
+    # ValueError: '/var/folders/12/mwcn15vx75l5_63v92hfws4r0000gp/T/tmpzfditoq4/invalid_actions.py'
+    # is not in the subpath of 'NeMo-Guardrails' OR one path is relative and the other is absolute.
+
+    with tempfile.TemporaryDirectory() as temp_dir:
+        module_path = Path(temp_dir) / "invalid_actions.py"
+        with open(module_path, "w") as f:
+            f.write("invalid python code")
+
+        dispatcher = ActionDispatcher(load_all_actions=False)
+        actions = dispatcher._load_actions_from_module(str(module_path))
+
+        assert actions == {}
+
+
+def test_load_actions_from_module_relative_path_exception(monkeypatch):
+    """Test loading actions from a module with invalid code"""
+
+    with tempfile.TemporaryDirectory() as temp_dir:
+        filename = "invalid_actions.py"
+        module_path = Path(temp_dir) / filename
+        with open(module_path, "w") as f:
+            f.write("invalid python code")
+
+        dispatcher = ActionDispatcher(load_all_actions=False)
+
+        # Mock the logger to capture the log messages
+        mock_logger = MagicMock()
+        monkeypatch.setattr("nemoguardrails.actions.action_dispatcher.log", mock_logger)
+
+        # Mock Path.cwd() to raise ValueError when calling relative_to
+        original_cwd = Path.cwd
+        monkeypatch.setattr(
+            "nemoguardrails.actions.action_dispatcher.Path.cwd",
+            lambda: (_ for _ in ()).throw(ValueError),
+        )
+
+        try:
+            actions = dispatcher._load_actions_from_module(str(module_path))
+        finally:
+            monkeypatch.setattr(
+                "nemoguardrails.actions.action_dispatcher.Path.cwd", original_cwd
+            )
+
+        assert actions == {}
+        mock_logger.error.assert_called()
+
+        error_message = mock_logger.error.call_args_list[-1][0][0]
+        assert f"Failed to register {filename}" in error_message
+
+        assert "invalid syntax" in error_message
+
+        assert "exception:" in error_message