Show all results publicly #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously students results would only be shown on the public scoreboard if equal to or better than the median score.
Remove /usr/bin prefix from compile commands (#70) Since commit 32dcf29 (add Java support, 2014-12-25), the compilation commands are executed using bash instead of directly using isolate. They no longer need the first argument to be the full path to the compiler. Note that the interpreter commands are still executed directly using isolate and need to keep using the full path to the interpreter. Co-authored-by: Tom Levy <[email protected]>
- Add two boolean feilds to the database live_scoreboard: If true, show problem scores on the live scoreboard show_unofficial_competitors: Mark non highschool students on scoreboard - Add these to the contest edit form - Update the scoreboard page itself Also: - Removed the contest info tab because it seems useless - Set the default tab to scoreboard if logged out - No longer show Owner ID from contest information - Use "hours" so that the duration setting is more clear
|
Edit page: Without problems showing: |
puqeko
commented
Apr 20, 2020
| @@ -27,8 +26,7 @@ | |||
| <td><%= contest.name %></td> | |||
| <td><%= contest.start_time.strftime("%b %d, %H:%M") unless contest.start_time.nil? %></td> | |||
| <td><%= contest.end_time.strftime("%b %d, %H:%M") unless contest.end_time.nil? %></td> | |||
| <td><%= contest.duration %></td> | |||
| <td><%= contest.owner_id %></td> | |||
| <td><%= contest.duration %> hours</td> | |||
There was a problem hiding this comment.
Self reminder to correctly pluralise this
There was a problem hiding this comment.
I think this is fine actually, "1.0 hours" sounds more correct than "1.0 hour".
https://english.stackexchange.com/questions/44489/is-1-0-singular-or-plural
| <% end %> | ||
| </p> | ||
| <% end %> | ||
| </p> |
| <p> | ||
| <b> Problem set: </b> | ||
| <%= link_to @contest.problem_set.name, @contest.problem_set %> | ||
| </p> |
| @@ -70,3 +70,6 @@ table.main_table > thead > tr > th { | |||
| font-weight: bold; | |||
| } | |||
|
|
|||
| .unofficial > td { | |||
| opacity: 0.4; | |||
| } | |||
| def change | ||
| add_column :contests, :show_unofficial_competitors, :boolean, :default => false | ||
| end | ||
| end |
| def change | ||
| add_column :contests, :live_scoreboard, :boolean, :default => true | ||
| end | ||
| end |
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously students results would only be shown on the public
scoreboard if equal to or better than the median score. I don't see any point to this - we may as well show the preliminary results publicly so people can keep an eye on the scoreboard without logging in.
Obsoleted by #123