pineflash: init at 0.5.4 #243312

Janik-Haag · 2023-07-13T18:05:33Z

Description of changes

https;//github.com/spagett1/pineFlash/

Things done

I have some problems with dfu-util when trying to flash a pinecil with pineflash it complaints about not finding dfu-util no matter iif I put it into buildInputs, nativeBuildInputs or propagatedBuildInputs what does work is spawning a nix-shell like that: nix-shell -p dfu-util and then opening pineflash from that nix-shell. I'm guessing this is caused by some wired behavior of $PATH but I don't know.

Janik-Haag · 2023-07-14T06:09:24Z

#227474 has to get merged before this one since blisp is needed to flash the pincil v2

Luflosi · 2023-11-05T14:44:35Z

blisp is now packaged. Does anything else need to be done before this PR is ready for merging?

danjujan

My suggestions for the latest version.

pkgs/tools/misc/pineflash/default.nix

Janik-Haag · 2023-11-10T14:23:22Z

Thanks for the review and the ping, I'll try to work on it this weekend :D

Janik-Haag · 2023-11-12T16:16:22Z

I applied your suggested patches and building works fine, but executing ./result/bin/pineflash results in A massive error occured, not sure whats goin on here. and funnily enough exit code 0. Do you have a idea why that happens?

danjujan · 2023-11-12T20:00:25Z

Works fine for me on Arch Linux with home-manager in a Gnome wayland session. I don't have a NixOS system to test this on at the moment. Maybe @Luflosi can help?
The error comes from these lines https://github.com/Spagett1/PineFlash/blob/d3527083b716979a6211ffc0395403de23c99b75/src/.main.rs.rustfmt#L526C1-L532C85. Maybe a missing dependency that causes eframe::run_native to fail?

Janik-Haag · 2023-11-12T20:37:25Z

Hmm I'm on Nixos unstable with sway

danjujan · 2023-11-13T19:53:02Z

emilk/egui#3104 seems related to your sway problem. Pineflash 0.5.3 bumped egui from version 0.21 to 0.22.

danjujan · 2023-12-09T19:58:48Z

Any news? Had the time to test pineflash in hyperland and sway. Works fine here.

Luflosi

How about moving this from pkgs/tools/misc/pineflash/default.nix to pkgs/by-name/pi/pineflash/package.nix? Then you don't need to change pkgs/top-level/all-packages.nix.

Janik-Haag · 2023-12-09T21:39:02Z

Any news? Had the time to test pineflash in hyperland and sway. Works fine here.

I wonder whats different on your host. I tried bisecting egui earlier but to no avail all the hello_world examples even the one from the 0.21 release fail with:

Failed to initialize any backend! Wayland status: NoWaylandLib X11 status: LibraryOpenError(OpenError { kind: Library, detail: "opening library failed (libX11.so.6: cannot open shared object file: No such file or directory); opening library failed (libX11.so: cannot open shared object file: No such file or directory)" })

How about moving this from pkgs/tools/misc/pineflash/default.nix to pkgs/by-name/pi/pineflash/package.nix? Then you don't need to change pkgs/top-level/all-packages.nix.

There will be a pr with automated tooling to do this. No need for extra manual labor

mweinelt · 2023-12-14T12:55:30Z

❯ ./result/bin/pineflash
A massive error occured, not sure whats goin on here.

On sway, x86_64-linux.

NovaViper · 2024-02-26T06:35:12Z

I tried this on NixOS unstable for my desktop (x86_64-linux) running KDE Plasma 5.27.10; I also got the A massive error occured, not sure whats goin on here. error too.

Janik-Haag · 2024-02-26T21:46:59Z

updated, but still getting the same error on wayland :(

NovaViper · 2024-02-27T05:51:00Z

I actually got a different error this time, same system. I also forgot to mention in my previous comment that my desktop is using X11 and not Wayland

A massive error occured, not sure whats goin on here:
 Found no glutin configs matching the template: ConfigTemplate { color_buffer_type: Rgb { r_size: 8, g_size: 8, b_size: 8 }, alpha_size: 8, depth_size: 0, stencil_size: 0, num_samples: None, min_swap_interval: None, max_swap_interval: None, config_surface_types: WINDOW, api: None, transparency: false, single_buffering: false, stereoscopy: None, float_pixels: false, max_pbuffer_width: None, hardware_accelerated: None, max_pbuffer_height: None, native_window: None }. error: Error { raw_code: None, raw_os_message: None, kind: NotFound }

Luflosi · 2024-02-27T09:20:51Z

I'm also getting

A massive error occured, not sure whats goin on here: 
 Found no glutin configs matching the template: ConfigTemplate { color_buffer_type: Rgb { r_size: 8, g_size: 8, b_size: 8 }, alpha_size: 8, depth_size: 0, stencil_size: 0, num_samples: None, min_swap_interval: None, max_swap_interval: None, config_surface_types: WINDOW, api: None, transparency: false, single_buffering: false, stereoscopy: None, float_pixels: false, max_pbuffer_width: None, hardware_accelerated: None, max_pbuffer_height: None, native_window: None }. error: Error { raw_code: None, raw_os_message: None, kind: NotFound }

I'm running GNOME with Wayland.

NovaViper · 2024-02-28T05:17:36Z

Hey I gave it a try once again after updating it and it's still erroring out on X11

A massive error occured, not sure whats goin on here:
 Found no glutin configs matching the template: ConfigTemplate { color_buffer_type: Rgb { r_size: 8, g_size: 8, b_size: 8 }, alpha_size: 8, depth_size: 0, stencil_size: 0, num_samples: None, min_swap_interval: None, max_swap_interval: None, config_surface_types: WINDOW, api: None, transparency: false, single_buffering: false, stereoscopy: None, float_pixels: false, max_pbuffer_width: None, hardware_accelerated: None, max_pbuffer_height: None, native_window: None }. error: Error { raw_code: None, raw_os_message: None, kind: NotFound }

Janik-Haag · 2024-02-28T21:40:56Z

I guess this is a upstream error and not one with our packaging but not sure.

danjujan

Upstream reworked its wayland code.

danjujan · 2024-05-04T20:03:34Z

pkgs/by-name/pi/pineflash/package.nix

+
+rustPlatform.buildRustPackage rec {
+  pname = "pineflash";
+  version = "0.5.4";


Suggested change

version = "0.5.4";

version = "0.5.5";

danjujan · 2024-05-04T20:07:11Z

pkgs/by-name/pi/pineflash/package.nix

+    owner = "Spagett1";
+    repo = "PineFlash";
+    rev = version;
+    hash = "sha256-4izfxApaCLbetZmMMKZIAknb+88B7z2WO+sBafehKHI=";


Suggested change

hash = "sha256-4izfxApaCLbetZmMMKZIAknb+88B7z2WO+sBafehKHI=";

hash = "sha256-4tcwEok36vuXbtlZNUkLNw1kHFQPBEJM/gWRhRWNLPg=";

danjujan · 2024-05-04T20:08:07Z

pkgs/by-name/pi/pineflash/package.nix

+    categories = [ "Utility" ];
+  })];
+
+  cargoHash = "sha256-VtUq/scRnx52ibqvUIqvaloaQpZyyXUlJYd2UIKQTjg=";


Suggested change

cargoHash = "sha256-VtUq/scRnx52ibqvUIqvaloaQpZyyXUlJYd2UIKQTjg=";

cargoHash = "sha256-l01It6mUflENlADW6PpOQvK1o4qOjbTsMLB6n+OIl0U=";

danjujan · 2024-05-04T20:11:35Z

pkgs/by-name/pi/pineflash/package.nix

+        --replace 'Command::new("dfu-util")' 'Command::new("${dfu-util}/bin/dfu-util")' \
+        --replace 'Command::new("blisp")' 'Command::new("${blisp}/bin/blisp")'
+  '';
+


Suggested change

postFixup = ''

patchelf $out/bin/${pname} \

--add-rpath ${lib.makeLibraryPath [libxkbcommon wayland]}

'';

Luflosi · 2024-05-05T11:31:08Z

With the new version I'm still getting the error :(

A massive error occured, not sure whats goin on here: 
 Found no glutin configs matching the template: ConfigTemplate { color_buffer_type: Rgb { r_size: 8, g_size: 8, b_size: 8 }, alpha_size: 8, depth_size: 0, stencil_size: 0, num_samples: None, min_swap_interval: None, max_swap_interval: None, config_surface_types: ConfigSurfaceTypes(WINDOW), api: None, transparency: false, single_buffering: false, stereoscopy: None, float_pixels: false, max_pbuffer_width: None, hardware_accelerated: None, max_pbuffer_height: None, native_window: None }. Error: Error { raw_code: None, raw_os_message: None, kind: NotFound }

I get the same error when I rebase the PR on top of the version of Nixpkgs I'm currently running on my NixOS system (5c24cf2) I also tried rebasing on top of the latest master with the same result.

acuteaangle · 2024-12-30T19:32:44Z

Whoops. I just found this PR.
I had opened gh-369458.

The 0 exit status with no stack trace was in part an upstream bug, which should be fixed in the next version.

strace revealed it to be crashing after searching for libxkbcommon-x11.so and libGL.so; patching the pkexec path and adding those to buildInputs and rpath resolved that specific issue.

How should we go about merging these—can anyone test if either of these function for them currently? My PR doesn’t have the desktop icons currently, and has not been tested on Darwin, but functions for me with X11 Cinnamon on x86_64-linux.

Note: The license is now out of date here, it was changed to gpl2Only.

Janik-Haag force-pushed the pine-flash branch from 9070db3 to d2de5e9 Compare July 13, 2023 20:01

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 13, 2023

Janik-Haag force-pushed the pine-flash branch from d2de5e9 to ae58407 Compare July 14, 2023 06:42

danjujan suggested changes Nov 8, 2023

View reviewed changes

Janik-Haag force-pushed the pine-flash branch 2 times, most recently from 188576b to 6403e0f Compare November 12, 2023 16:17

Janik-Haag marked this pull request as ready for review November 12, 2023 16:17

Janik-Haag requested a review from danjujan November 12, 2023 16:17

Janik-Haag changed the title ~~pineflash: init at 0.5.1~~ pineflash: init at 0.5.3 Nov 12, 2023

danjujan approved these changes Dec 9, 2023

View reviewed changes

Luflosi suggested changes Dec 9, 2023

View reviewed changes

Janik-Haag mentioned this pull request Dec 16, 2023

wl-screenrec: unstable-2023-09-17 -> 0.1.3 #273965

Merged

13 tasks

Janik-Haag changed the title ~~pineflash: init at 0.5.3~~ pineflash: init at 0.5.4 Feb 26, 2024

Janik-Haag force-pushed the pine-flash branch from 6403e0f to b81fc4c Compare February 26, 2024 21:46

pineflash: init at 0.5.4

5ad3090

Janik-Haag force-pushed the pine-flash branch from b81fc4c to 5ad3090 Compare February 27, 2024 06:53

danjujan reviewed May 4, 2024

View reviewed changes

FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 14, 2024

acuteaangle mentioned this pull request Jan 1, 2025

pineflash: init at 0.5.5 #369458

Merged

13 tasks

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025

SigmaSquadron removed the awaiting_changes (old Marvin label, do not use) label Jan 5, 2025

GaetanLepage closed this in #369458 Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pineflash: init at 0.5.4 #243312

pineflash: init at 0.5.4 #243312

Janik-Haag commented Jul 13, 2023 •

edited

Loading

Janik-Haag commented Jul 14, 2023

Luflosi commented Nov 5, 2023

danjujan left a comment

Janik-Haag commented Nov 10, 2023

Janik-Haag commented Nov 12, 2023

danjujan commented Nov 12, 2023

Janik-Haag commented Nov 12, 2023

danjujan commented Nov 13, 2023

danjujan commented Dec 9, 2023

Luflosi left a comment

Janik-Haag commented Dec 9, 2023

mweinelt commented Dec 14, 2023 •

edited

Loading

NovaViper commented Feb 26, 2024 •

edited

Loading

Janik-Haag commented Feb 26, 2024

NovaViper commented Feb 27, 2024

Luflosi commented Feb 27, 2024

NovaViper commented Feb 28, 2024

Janik-Haag commented Feb 28, 2024

danjujan left a comment

danjujan May 4, 2024

danjujan May 4, 2024

danjujan May 4, 2024

danjujan May 4, 2024

Luflosi commented May 5, 2024

acuteaangle commented Dec 30, 2024 •

edited

Loading

	hash = "sha256-4izfxApaCLbetZmMMKZIAknb+88B7z2WO+sBafehKHI=";
	hash = "sha256-4tcwEok36vuXbtlZNUkLNw1kHFQPBEJM/gWRhRWNLPg=";

	cargoHash = "sha256-VtUq/scRnx52ibqvUIqvaloaQpZyyXUlJYd2UIKQTjg=";
	cargoHash = "sha256-l01It6mUflENlADW6PpOQvK1o4qOjbTsMLB6n+OIl0U=";

+  postFixup = ''
+    patchelf $out/bin/${pname} \
+      --add-rpath ${lib.makeLibraryPath [libxkbcommon wayland]}
+  '';

pineflash: init at 0.5.4 #243312

pineflash: init at 0.5.4 #243312

Conversation

Janik-Haag commented Jul 13, 2023 • edited Loading

Description of changes

Things done

Janik-Haag commented Jul 14, 2023

Luflosi commented Nov 5, 2023

danjujan left a comment

Choose a reason for hiding this comment

Janik-Haag commented Nov 10, 2023

Janik-Haag commented Nov 12, 2023

danjujan commented Nov 12, 2023

Janik-Haag commented Nov 12, 2023

danjujan commented Nov 13, 2023

danjujan commented Dec 9, 2023

Luflosi left a comment

Choose a reason for hiding this comment

Janik-Haag commented Dec 9, 2023

mweinelt commented Dec 14, 2023 • edited Loading

NovaViper commented Feb 26, 2024 • edited Loading

Janik-Haag commented Feb 26, 2024

NovaViper commented Feb 27, 2024

Luflosi commented Feb 27, 2024

NovaViper commented Feb 28, 2024

Janik-Haag commented Feb 28, 2024

danjujan left a comment

Choose a reason for hiding this comment

danjujan May 4, 2024

Choose a reason for hiding this comment

danjujan May 4, 2024

Choose a reason for hiding this comment

danjujan May 4, 2024

Choose a reason for hiding this comment

danjujan May 4, 2024

Choose a reason for hiding this comment

Luflosi commented May 5, 2024

acuteaangle commented Dec 30, 2024 • edited Loading

Janik-Haag commented Jul 13, 2023 •

edited

Loading

mweinelt commented Dec 14, 2023 •

edited

Loading

NovaViper commented Feb 26, 2024 •

edited

Loading

acuteaangle commented Dec 30, 2024 •

edited

Loading