Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pineflash: init at 0.5.5 #369458

Merged
merged 2 commits into from
Jan 22, 2025
Merged

pineflash: init at 0.5.5 #369458

merged 2 commits into from
Jan 22, 2025

Conversation

acuteaangle
Copy link
Contributor

@acuteaangle acuteaangle commented Dec 30, 2024

Closes: gh-297715
Closes: gh-243312

This PR adds PineFlash, a graphical utility for easily flashing IronOS to Pinecil soldering irons.

Note: This is my first package submission to nixpkgs, so I would greatly appreciate anyone reviewing or testing this pointing out anything obvious I missed, or any other advice/suggestions :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 30, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 30, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 30, 2024
@acuteaangle acuteaangle mentioned this pull request Dec 30, 2024
12 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 31, 2024
@acuteaangle
Copy link
Contributor Author

I have become aware of a duplicate PR for an older version at gh-243312.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 labels Jan 1, 2025
@acuteaangle
Copy link
Contributor Author

acuteaangle commented Jan 1, 2025

Since the previous PR seems stalled with unresolved issues, I intend to move forward with this one.


Todo before this is ready for review:

  • Merge in desktop item from pineflash: init at 0.5.4 #243312
    • Seems like upstream has a .desktop file, need to check why that’s not being installed
  • Merge in Darwin-specific fixes from pineflash: init at 0.5.4 #243312
    • The substitutes should be included, but I am not familiar enough with Darwin and can’t personally test on Darwin to know which of the buildInputs are necessary; for now, I’ve left them out.
  • Re-test
  • Find out if @Janik-Haag still wishes to be listed as a maintainer for PineFlash
    • I was unaware as a new contributor, but it seems they have left Nix as a whole due to drama.
    • I have kept them as ‘Co-authored-by’, since I have integrated nontrivial parts of their PR into this one and I feel that is the most correct git history.

@acuteaangle acuteaangle force-pushed the pineflash branch 3 times, most recently from 0628ddc to 1258a13 Compare January 7, 2025 04:46
@acuteaangle
Copy link
Contributor Author

acuteaangle commented Jan 7, 2025

Corrected unnecessary string conversion ("${version}" → version), re-tested.

pkgs/by-name/pi/pineflash/package.nix Show resolved Hide resolved
pkgs/by-name/pi/pineflash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pineflash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pineflash/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pineflash/package.nix Outdated Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369458


x86_64-linux

✅ 1 package built:
  • pineflash

aarch64-linux

✅ 1 package built:
  • pineflash

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, this is a great first PR :)

@GaetanLepage GaetanLepage merged commit 60edc6e into NixOS:master Jan 22, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Pineflash
4 participants