-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pineflash: init at 0.5.5 #369458
pineflash: init at 0.5.5 #369458
Conversation
I have become aware of a duplicate PR for an older version at gh-243312. |
Since the previous PR seems stalled with unresolved issues, I intend to move forward with this one. Todo before this is ready for review:
|
0628ddc
to
1258a13
Compare
Corrected unnecessary string conversion ("${version}" → version), re-tested. |
1258a13
to
48d2ffd
Compare
48d2ffd
to
227ab13
Compare
Co-authored-by: Janik H. <[email protected]>
227ab13
to
06489c0
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, this is a great first PR :)
Closes: gh-297715
Closes: gh-243312
This PR adds PineFlash, a graphical utility for easily flashing IronOS to Pinecil soldering irons.
Note: This is my first package submission to nixpkgs, so I would greatly appreciate anyone reviewing or testing this pointing out anything obvious I missed, or any other advice/suggestions :)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.