-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
horizon-eda: fix build #358910
horizon-eda: fix build #358910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and runs without issues
Builds and works on my machine. @NixOS/nixpkgs-merge-bot merge |
After looking into separate commits I noticed 6b889c9 has some changes that are just formatting and not directly related to the build failure fix. I'd suggest to move those changes into the other nixfmt commit. |
6b889c9
to
ab380b8
Compare
@jue89 Done. |
@Bot-wxt1221 thanks! Hint for the next time: try not to rebase your PR ... the diff between the old and new head is quite large (but out-of-scope). I've manually checked that the current head creates the same binary compared to the old head, which is the case. My ACK still applies. |
Successfully created backport PR for |
ZHF: #352882
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.