Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] horizon-eda: fix build #359670

Merged
merged 2 commits into from
Dec 1, 2024
Merged

[Backport release-24.11] horizon-eda: fix build #359670

merged 2 commits into from
Dec 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.11, triggered by a label in #358910.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@Bot-wxt1221 @github-actions
horizon-eda: nixfmt
f839dd4 
(cherry picked from commit 8f1334f)
@Bot-wxt1221 @github-actions
horizon-eda: fix build
5bea575 
(cherry picked from commit ab380b8)
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
13 tasks
@ofborg ofborg bot requested review from jue89 and guserav November 28, 2024 16:24
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 28, 2024
jue89
jue89 approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@jue89 jue89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 359670 run on x86_64-linux 1

1 package built:
  • horizon-eda

@jue89 jue89 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 1, 2024
@wolfgangwalther wolfgangwalther merged commit c341b29 into release-24.11 Dec 1, 2024
21 of 22 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-358910-to-release-24.11 branch December 1, 2024 18:29
@jue89
Copy link
Contributor

jue89 commented Dec 2, 2024

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jue89 jue89 jue89 approved these changes

@guserav guserav Awaiting requested review from guserav

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jue89 @wolfgangwalther @Bot-wxt1221