apply changes from yesterdays review meeting #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumrollo
requested review from
glidermann,
vturpin,
castelao,
justinbuck,
kerfoot,
tcarval and
emmerbodc
as code owners
vturpin
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thanks Callum for the hard work.
I am happy to approve this PR as it is. It clarifies the document more and more. So you can close the discussion I've raised to merge.
However, a discussion is needed about some *_vocabularies, as I think we are missing the m2m benefit if we only link to the uri of the collection and not the uri of the term itself.
I'll open an issue about this not to forget the point.
We will need a second round of review anyway.
emmerbodc
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers
Type of PR
This addressed the lion's share of todo items from yesterday documented in #215
@emmerbodc @vturpin please review at your earliest convenience. Once this is merged I'll assign and resolve the remaining items in #215