Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luis add email notifcation to warning tracker backend #1123
Luis add email notifcation to warning tracker backend #1123
Changes from 23 commits
4f41d5e
74c7850
7eb0a65
bd8c58d
301fd28
c1d6c76
161b2c1
fa01786
ab1e953
081c5a5
da17641
78ee068
91e8398
05a7524
423c866
d998541
92b2ec1
2ab3c4b
73d14f9
f74c289
af2df1c
455c379
773186d
4de52b7
339a1fe
1c4b4e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors shouldn't be returning a
200
code, a generic400
should be enough. And why is errors returning two different bodies? ({ message: string }
and{ error: string }
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
Thanks for the feedback!
I send a 200 because if I send a 400 error, there is a red warning that appears in the console and wanted to avoid that. After reaching out team members this was the solution