Luis add email notifcation to warning tracker backend #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de to prevent post method from crashing
…d blue square is issued
… user data by creating an object
luisarevalo21
added
the
Do Not Review
luisarevalo21
removed
the
Do Not Review
Ankuriboh
previously requested changes
Oct 16, 2024
|
|
||
| const testWarning = checkIfSpecialCharacter(newWarning); | ||
| if (testWarning) { | ||
| return res.status(200).send({ |
There was a problem hiding this comment.
Errors shouldn't be returning a 200 code, a generic 400 should be enough. And why is errors returning two different bodies? ({ message: string } and { error: string })
There was a problem hiding this comment.
Hello
Thanks for the feedback!
I send a 200 because if I send a 400 error, there is a red warning that appears in the console and wanted to avoid that. After reaching out team members this was the solution
|
Thank you all, merging! |
one-community
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backend for sending an email,
Notable changes were, adding new functions to send the email, adjusted the filter method, and added helper functions to get the admin of the team .
Related PRS (if any):
To test this backend PR you need to checkout the #2752 frontend PR.
…
Main changes explained:
--created helper functions to send an email, but filtering and fetching the admin of the team.
--adjust filtering to check if an email should or shouldn't be sent
How to test:
npm run build && npm run startNote:
Ensure you follow the steps of the Frontend PR and Ivy Chen's PR.