Luis add email notification to warning tracker #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d send blue square to modal
luisarevalo21
added
the
do not review
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
luisarevalo21
removed
the
do not review
luisarevalo21
requested review from
Parth-tech,
Abi-Liu,
KyreneAF,
angelalalacheng and
strallia
Ankuriboh
requested changes
Oct 16, 2024
| @@ -35,10 +40,10 @@ export const postWarningByUserId = warningData => { | |||
| const response = await dispatch(postWarningsByUserId(res.data)); | |||
| return response.payload.warnings; | |||
| } catch (error) { | |||
| if (error.response && error.response.status === 400) { | |||
| return { error: 'Error occured when posting' }; | |||
| if (error.response && error.response.status === 200) { | |||
There was a problem hiding this comment.
Errors should never get a 200, this also requires backend changes.
| e.preventDefault(); | ||
|
|
||
| if (newWarning === '') return; | ||
| const trimmedWarning = newWarning.trim(); |
There was a problem hiding this comment.
I would suggest adding frontend validation for special characters, even though backend already had it.
Hey, I am trying to follow the steps in a YouTube video for OAuth authentication. I got to the 'app isn't verified' step, but in the video, there is an option to continue by clicking 'Advanced.' However, I don't see this option in my case. I have attached a screenshot for your reference. Please help if you have any ideas. |
|
Thank you all, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, first addressed an issue that crashed when opening the tracking modal.
Next it added email integration, sending an email when a user receives more than 3 warnings.
Different emails are sent when receiving a warning, and 'issuing a blue square'
Note: a blue isn't assigned it only emails the user saying they received one. That'll be another PR.
Related PRS (if any):
This frontend PR is related to the #1123 backend PR .
…
Main changes explained:
Created new helper functions to send an email.
Fetched the team leads emails to cc them in the email when issuing a warning.
Adjusted the filtering method to created a flag of when to send an email
How to test:
**Before testing this branch, please follow the instructions from this PR, you must follow this exactly, and have a google auth key in order to send an email. **
OneCommunityGlobal/HGNRest#829
If you have questions/issues with this step I'd be more than happy to help.
Another note:
Ensure you have 2 emails one to receive the email and another to be cc'd.
npm installand...to run this PR locallywarningsController.jsand change theemailSenderto your email for both the issue warning and blue square. The first parameter will be the one who is being issued the warning. You'll add your email after a comma.getUserRoleByEmailFunction. You can add your email in the recipients array.Issuing Warning:
Issuing Blue square:
Screenshots or videos of changes:
Screen.Recording.2024-10-04.at.8.59.31.PM.mov
Screen.Recording.2024-10-04.at.9.00.10.PM.mov
Note:
Before starting, to review this PR, you must have a google auth key to send emails. Follow the PR attached, and feel free to reach out if you get stuck.