GameDB: Add NTSC-C game's official Simplified Chinese name #10488
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
| name: "Viorate no Atelier - Gramnad no Renkinjutsushi 2" | ||
| name: 薇欧蕾特的工房 ～古拉姆那特的炼金术士2～ | ||
| name-sort: "Wei'ouleite De Gongfang - Gulamunate De Lianjinshushi 2 -" | ||
| name-en: "Viorate no Atelier - Gramnad no Renkinjutsushi 2" |
There was a problem hiding this comment.
Shouldn't it be Atelier Violet ?
There was a problem hiding this comment.
same as mentioned below, keeping what we had is correct.
| name: "Saru EyeToy - Oosawagi! Ukkiuki Game Tenkomori!!" | ||
| name: 比波猴@爱淘儿 一起欢聚比波猴乐园吧！ | ||
| name-sort: "Bibohou Aitao'er Yiqi Huanju Bibohou Leyuan Ba!" | ||
| name-en: "Saru EyeToy - Oosawagi! Ukkiuki Game Tenkomori!!" |
There was a problem hiding this comment.
EyeToy - Monkey Mania
There was a problem hiding this comment.
I don't think it should be, it should be what it was originally in the gamedb, which is what they've done.
| region: "NTSC-C" | ||
| SCCS-40004: | ||
| name: "XIGO - Zuihou de Touzi" | ||
| name: XIGO: 最后的骰子 |
There was a problem hiding this comment.
it's probably upset that you used : and not -
you should replace that, same with the line below
There was a problem hiding this comment.
As far as I can tell, every reference to the Chinese title of the game use colon.
This should be a convention to use "additional names" when naming games in Chinese.
P.S. It was my mistake to use a non-full-width colon. I think it should be a full-width colon for all Chinese content。
There was a problem hiding this comment.
You can't use colons in the names in the db so you have to use a dash.
There was a problem hiding this comment.
Even if the original title contains a colon?
There was a problem hiding this comment.
Got it. Will fixed.
There was a problem hiding this comment.
Thank you, let's see if it passes now
There was a problem hiding this comment.
Sorry for the confusion, you can use colons if the original titles contain colons after #10494 is merged.
There was a problem hiding this comment.
What about cover images? They are one of the primary reasons why they weren't used as it will silent fail on this aspect.
There was a problem hiding this comment.
Cover images should already be fine on master. The path is sanitized to replace any illegal characters with underscores.
|
sorry for a copy mistake... now should be fine? |
|
You need to use the quotes to wrap them in for the Chinese name serials. As you see on the English section: |
none of the asian names have been encapsulted in quotes. though if they have colons, they are gonna need them. looks like the ~ might be freaking it out too, so you'll need to quote those. Are they actually words? if not they can be omitted. |
|
Looks like I need to reexamine these game's real cover images... Back soon. |
| name: "Super Puzzle Bobble 2" | ||
| name: 超级泡泡龙 2 | ||
| name-sort: "Chaoji Paopaolong 2" | ||
| nam-en: "Super Puzzle Bobble 2" |
There was a problem hiding this comment.
| nam-en: "Super Puzzle Bobble 2" | |
| name-en: "Super Puzzle Bobble 2" |
| region: "NTSC-C" | ||
| SCCS-40009: | ||
| name: "Dragon Ball Z 2" | ||
| name: 龙珠二世 |
There was a problem hiding this comment.
| name: 龙珠二世 | |
| name: "龙珠二世" |
Same for other serials, should be fine then.
nebulas-star
changed the title
|
～ sure in SCCS-40015 so already quote it. Other already remove. They should now conform to the cover images and/or in-game title images. |
|
Thanks :) |
Add NTSC-C game's official chinese name in GameDB, also a transliteration (Hanyu Pinyin) for sorting.
This addition is to make it easier to search the game using the official Chinese name.
Copy from Here.