Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Add NTSC-C game's official Simplified Chinese name #10488

Merged
merged 7 commits into from
Dec 30, 2023
+59 −18
Merged

GameDB: Add NTSC-C game's official Simplified Chinese name #10488

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50ee1a4
Add NTSC-C game's official chinese name
nebulas-star Dec 27, 2023
d93a305
Fix colon
nebulas-star Dec 28, 2023
ac5e13e
Removed punctuation for Chinese game sorting name
nebulas-star Dec 28, 2023
851b5af
Fix Bug
nebulas-star Dec 28, 2023
74f221e
Fix Error (Sorry...)
nebulas-star Dec 28, 2023
d0d0b1f
Clean up the title symbol to match the cover
nebulas-star Dec 28, 2023
cd0e04b
Fix copy error
nebulas-star Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 59 additions & 18 deletions bin/resources/GameIndex.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2102,24 +2102,34 @@
roundSprite: 1 # Fixes chromatic effect.
autoFlush: 1 # Fixes sun occlusion.
SCCS-40001:
name: "Ape Escape 2"
name: 捉猴啦 2
name-sort: "Zhuo Hou La 2"
name-en: "Ape Escape 2"
region: "NTSC-C"
gameFixes:
- SoftwareRendererFMVHack # Fixes interlacing.
gsHWFixes:
mipmap: 2 # Fixes miptrick texture effects.
trilinearFiltering: 1 # Fixes miptrick blending.
SCCS-40002:
name: "Devil May Cry 2 - Disc 1"
name: 恶魔猎人2 (Disc 1)
name-sort: "'E'mo Lieren 2 (Disc 1)"
name-en: "Devil May Cry 2 - Disc 1"
region: "NTSC-C"
SCCS-40003:
name: "Devil May Cry 2 - Disc 2"
name: 恶魔猎人2 (Disc 2)
name-sort: "'E'mo Lieren 2 (Disc 2)"
name-en: "Devil May Cry 2 - Disc 2"
region: "NTSC-C"
SCCS-40004:
name: "XIGO - Zuihou de Touzi"
name: XIGO: 最后的骰子

Check failure on line 2125 in bin/resources/GameIndex.yaml

View workflow job for this annotation

GitHub Actions / Lint and Validate GameDB 

2125:13 syntax error: mapping values are not allowed here (syntax)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XIGO：最后的骰子

Copy link
Member

@refractionpcsx2 refractionpcsx2 Dec 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably upset that you used : and not -
you should replace that, same with the line below

Copy link
Contributor Author

@nebulas-star nebulas-star Dec 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, every reference to the Chinese title of the game use colon.
This should be a convention to use "additional names" when naming games in Chinese.

P.S. It was my mistake to use a non-full-width colon. I think it should be a full-width colon for all Chinese content。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use colons in the names in the db so you have to use a dash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the original title contains a colon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Will fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, let's see if it passes now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, you can use colons if the original titles contain colons after #10494 is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about cover images? They are one of the primary reasons why they weren't used as it will silent fail on this aspect.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cover images should already be fine on master. The path is sanitized to replace any illegal characters with underscores.

name-sort: "XIGO: Zuihou de Touzi"
name-en: "XIGO - Zuihou de Touzi"
region: "NTSC-C"
SCCS-40005:
name: "Ico"
name: ICO 古堡迷踪
name-sort: "ICO Gubao Mizong"
name-en: "Ico"
region: "NTSC-C"
compat: 5
clampModes:
Expand All @@ -2130,51 +2140,82 @@
halfPixelOffset: 1 # Fixes effect misalignment.
moveHandler: "MV_Ico" # Fixes depth buffer post-processing.
SCCS-40006:
name: "Zhen Sanguo Wushuang 2"
name: 真·三国無双2
name-sort: "Zhen - Sanguo Wushuang 2"
name-en: "Zhen Sanguo Wushuang 2"
region: "NTSC-C"
SCCS-40007:
name: "Arc the Lad - Seirei no Tasogare"
name: 亚克传承　～精灵之黄昏～
name-sort: "Yake Chuancheng - Jingling Zhi Huanghun -"
nam-ene: "Arc the Lad - Seirei no Tasogare"
region: "NTSC-C"
SCCS-40009:
name: "Dragon Ball Z 2"
name: 龙珠二世
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 龙珠二世
name: "龙珠二世"

Same for other serials, should be fine then.

name-sort: "Longzhu Ershi"
name-en: "Dragon Ball Z 2"
region: "NTSC-C"
SCCS-40010:
name: "Super Puzzle Bobble 2"
name: 超级泡泡龙 2
name-sort: "Chaoji Paopaolong 2"
nam-en: "Super Puzzle Bobble 2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nam-en: "Super Puzzle Bobble 2"
name-en: "Super Puzzle Bobble 2"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a spot

region: "NTSC-C"
SCCS-40011:
name: "Armored Core 2 - Another Age"
name: 机战佣兵2
name-sort: "Jizhan Yongbing 2"
name-en: "Armored Core 2 - Another Age"
region: "NTSC-C"
SCCS-40012:
name: 格斗擂台4 进化版
name-sort: "Gedou Leitai 4 Jinhuaban"
name-en: "Virtua Fighter 4 Evolution"
region: "NTSC-C"
SCCS-40014:
name: "World Soccer Winning Eleven 7 - International"
name: 实况足球 胜利十一人7 国际版
name-sort: "Shikuang Zuqiu Shengli Shiyi Ren 7 Guojiban"
name-en: "World Soccer Winning Eleven 7 - International"
region: "NTSC-C"
SCCS-40015:
name: "Viorate no Atelier - Gramnad no Renkinjutsushi 2"
name: 薇欧蕾特的工房 ～古拉姆那特的炼金术士2～
name-sort: "Wei'ouleite De Gongfang - Gulamunate De Lianjinshushi 2 -"
name-en: "Viorate no Atelier - Gramnad no Renkinjutsushi 2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be Atelier Violet ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as mentioned below, keeping what we had is correct.

region: "NTSC-C"
SCCS-40016:
name: "Ape Escape - Pumped & Primed"
name: 比波猴百斗派对
name-sort: "Bibohou Baidou Paidui"
name-en: "Ape Escape - Pumped & Primed"
region: "NTSC-C"
gsHWFixes:
halfPixelOffset: 2 # Corrects fullscreen bloom misalignment.
SCCS-40017:
name: "EyeToy - Play"
name: 爱淘儿
name-sort: "AiTao'er"
name-en: "EyeToy - Play"
region: "NTSC-C"
compat: 5
SCCS-40018:
name: "Saru EyeToy - Oosawagi! Ukkiuki Game Tenkomori!!"
name: 比波猴@爱淘儿 一起欢聚比波猴乐园吧！
name-sort: "Bibohou Aitao'er Yiqi Huanju Bibohou Leyuan Ba!"
name-en: "Saru EyeToy - Oosawagi! Ukkiuki Game Tenkomori!!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EyeToy - Monkey Mania

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be, it should be what it was originally in the gamedb, which is what they've done.

region: "NTSC-C"
compat: 5
SCCS-40019:
name: "Formula One 04"
region: "NTSC-C"
SCCS-40022:
name: "World Soccer Winning Eleven 8 - Asia Championship"
name: 实况足球 胜利十一人 8 亚洲冠军联赛
name-sort: "Shikuang Zuqiu Shengli Shiyi Ren 8 Yazhou Guanjunliansai"
name-en: "World Soccer Winning Eleven 8 - Asia Championship"
region: "NTSC-C"
compat: 5
SCCS-60001:
name: "Sakura Taisen - Atsuki Chishio Ni"
name: 樱花大战: 炽热之血
name-sort: "Yinghua Dazhan: Chire Zhi Xue"
name-en: "Sakura Taisen - Atsuki Chishio Ni"
region: "NTSC-C"
SCCS-60002:
name: "Gran Turismo 4 [Review Copy]"
name: 跑车浪漫旅 4
name-sort: "Paoche Langmanlu 4"
name-en: "Gran Turismo 4 [Review Copy]"
region: "NTSC-C"
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
Expand Down
Loading