Containerized the Interface and Visualization And Setup Github Actions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added install dependencies section
Co-authored-by: Chris Schnaufer <[email protected]>
Co-authored-by: Chris Schnaufer <[email protected]>
Co-authored-by: David LeBauer <[email protected]>
Co-authored-by: David LeBauer <[email protected]>
Delete client.json Delete package-lock.json
Added install dependencies section
Co-authored-by: Chris Schnaufer <[email protected]> alt text
Update upload1.js Fixed redirects and error page functionality Update app/Meta.py Co-authored-by: Chris Schnaufer <[email protected]> Update app/Meta.py Co-authored-by: David LeBauer <[email protected]> Replace "some text" with "" in Meta.py Co-authored-by: David LeBauer <[email protected]>
|
Please have a look at it and then merge it |
|
My comment from above:
wasn't intended to for combining all the testing scripts - sorry I wasn't clear. The key to my request was to simplify things, not make them more complex. The idea was to see if matrix could be used to combine the two Python tests into one file. I feel that putting Python and Node tests into the same file defeats simplification. If putting the Python app-test and client-tests into the same file using matrix makes things less simple, then that shouldn't be done. |
Chris-Schnaufer
requested changes
Aug 24, 2020
Chris-Schnaufer
requested changes
Aug 31, 2020
Chris-Schnaufer
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have containerized the interface and visualization part of the YABA app in this PR
Please look at the Dockerfile - this commit 6037b55 and below. (Other files are from when the initial creation of the interface and visualization and will no longer be relevant after current work is submitted.)