-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed the Third Phase Targets for GSOC #69
Conversation
@im-prakher whether I put in my real API key from the TERRA REF Bety or some random characters, I get this error. And this is the pop up window after I put a key in and hit the start button. What is supposed to go in as |
@KristinaRiemer Bety database image currently doesn't contain apikey for any user so it couldn't find it for you. Meanwhile, I will make a commit so that it displays an appropriate message for this. Here's the issue for this |
@KristinaRiemer Also, you can insert the API key for any user if you want by using these comands,
|
@KristinaRiemer This error is now solved in #41db3ae |
@im-prakher I just went through this PR to see how everything worked. I'm documenting all the steps I took here, in case I did something wrong and also because there were a few issues. I removed all of the existing containers, including the database, to prevent duplicate data errors with I opened the app and put in the API key after following these instructions, and that went great. The three visualization pages also looked good except for one thing. When I clicked on the plots in the experiment viz, they said they were locations at range 39, but the input data in experiments_sites.csv said range 20. (See screenshot below) Why are those different? Then after the visualization pages, I got this not iterable error on the following page: Lastly, I checked the data validation. I redid all the steps from above to remove and recreate the containers to make sure there was no example data in the database already. I then removed the first column ( There was an error on the next page for the cultivars visualization: |
@KristinaRiemer The difference between the ranges of plots in viz part is due to the different sitename in the experiments table and shapefiles, e.g. We have discussed this type of situation during the GSoC meeting and we planned to get the sitename for plots from shapefile |
The iterable error that occurred for three tables is because the insert_sites route isn't working properly and all these tables are dependent on the sites table which must be uploaded before uploading them. Once the sites route is fixed, it will work. |
I'll look into the validation error, it must be something about the yaba_api code in python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments for improving documentation, and optional suggestions for code improvements
@im-prakher great, thank you for the explanations about the plot names and iterable error! With respect to the validation error, the error shown in the screenshot is correct, I think. The problem is that the validation page said that all of the tables were valid, even though I had purposely changed the cultivars table so that it wasn't valid. The validation page should return that there is something wrong with the cultivars table, I believe? |
Co-authored-by: Chris Schnaufer <[email protected]>
Co-authored-by: Chris Schnaufer <[email protected]>
Co-authored-by: Chris Schnaufer <[email protected]>
Attempt to fix merge conflicts for PR 69
Targets achieved in this PR -
Visualized the polygons as they should have been, also modified the tests for that in #0dcd13f.
Implemented Data Validation and Improved Error Logging & Handling in #629583f and #1c39008
Improved SheetToCSV functionality in #ca9adac
API Key Validation done in #6842d16
Changed the Docker container ports for visualization #ed56e5c
Completed the documentation of YABA App #8b3c15c
Also before merging this PR please merge #63.
Kindly review @dlebauer @KristinaRiemer @Chris-Schnaufer