feat: add values for m_ChangedBitFlag, populate unknown fields of FriendPersistentInfo for Friends (3DS) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniElectra
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Nice work! Do you also happen to know anything about the AccountExtraInfo or the NintendoCreateAccountData structures?
| | Uint8 | Area | | ||
| | Uint8 | Language | | ||
| | Uint8 | Platform | | ||
| | Uint64 | Local friend code seed | |
There was a problem hiding this comment.
Is this the Local Friend Code Seed or the Local Friend Code? The terminology is different (The "Local Friend Code" includes seemingly random data on the upper 16 bits, whereas the "Local Friend Code Seed" doesn't)
Comment on lines
+513
to
+523
| | Flag | Description | | ||
| | ----------------------------- | --------------------------------------- | | ||
| | 1 | [Game Key](#gamekey-structure) changed. | | ||
| | 2 | Game mode description changed. | | ||
| | 4 | Join availability flag changed. | | ||
| | 8 | Matchmake system type changed. | | ||
| | 16 | Join game ID changed. | | ||
| | 32 | Join game mode changed. | | ||
| | 64 | Owner [PID] changed. | | ||
| | 128 | Join group ID changed. | | ||
| | 256 | Application argument changed. | |
There was a problem hiding this comment.
Can you represent the flags in hex instead of decimal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #XXX
Changes:
Add values for the
m_ChangedBitFlagenum inNintendoPresenceand the remaining "Unknown" fields inMyProfilebased on reverse engineering of the 3DS friends module.