Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add values for m_ChangedBitFlag, populate unknown fields of FriendPersistentInfo for Friends (3DS) #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add values for m_ChangedBitFlag, populate unknown fields of FriendPersistentInfo for Friends (3DS) #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions docs/nex/protocols/friends-3ds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,16 +480,16 @@ Character sets:
> This structure [inherits](/docs/nex/types#structure-inheritance) from [Data]
{: .prompt-info }

| Type | Description |
| -------- | ----------- |
| Uint8 | Region |
| Uint8 | Country |
| Uint8 | Area |
| Uint8 | Language |
| Uint8 | Platform |
| Uint64 | Unknown |
| [String] | Unknown |
| [String] | Unknown |
| Type | Description |
| -------- | ---------------------- |
| Uint8 | Region |
| Uint8 | Country |
| Uint8 | Area |
| Uint8 | Language |
| Uint8 | Platform |
| Uint64 | Local friend code seed |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the Local Friend Code Seed or the Local Friend Code? The terminology is different (The "Local Friend Code" includes seemingly random data on the upper 16 bits, whereas the "Local Friend Code Seed" doesn't)

| [String] | Console MAC address |
| [String] | Console serial number |

### NintendoPresence ([Structure])
> This structure [inherits](/docs/nex/types#structure-inheritance) from [Data]
Expand All @@ -508,6 +508,20 @@ Character sets:
| Uint32 | m_joinGroupID |
| [Buffer] | m_applicationArg |

Change bit flags:

| Flag | Description |
| ----------------------------- | --------------------------------------- |
| 1 | [Game Key](#gamekey-structure) changed. |
| 2 | Game mode description changed. |
| 4 | Join availability flag changed. |
| 8 | Matchmake system type changed. |
| 16 | Join game ID changed. |
| 32 | Join game mode changed. |
| 64 | Owner [PID] changed. |
| 128 | Join group ID changed. |
| 256 | Application argument changed. |
Comment on lines +513 to +523
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you represent the flags in hex instead of decimal?


### PlayedGame ([Structure])
> This structure [inherits](/docs/nex/types#structure-inheritance) from [Data]
{: .prompt-info }
Expand Down