Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BUILD files for test-declaration consistency #4457

Closed
jwnimmer-tri opened this issue Dec 11, 2016 · 1 comment · Fixed by #4459
Closed

Update BUILD files for test-declaration consistency #4457

jwnimmer-tri opened this issue Dec 11, 2016 · 1 comment · Fixed by #4459
Assignees
@jwnimmer-tri
Labels
configuration: bazel priority: high type: cleanup

Comments

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Dec 11, 2016 •
edited
Loading

Before using Bazel with a wider audience, we should be internally consistent. One big divergence is declaring tests, e.g., in foo/BUILD vs foo/test/BUILD. We've agreed to use foo/BUILD, so fix the tree to be consistent.

This is part of #3129.
@jwnimmer-tri jwnimmer-tri self-assigned this Dec 11, 2016
@jwnimmer-tri
Copy link
Collaborator Author

Code is ready at https://github.com/jwnimmer-tri/drake/tree/bazel-refactor_test_rules but needs #4453 to merge first.

@jwnimmer-tri jwnimmer-tri mentioned this issue Dec 12, 2016
Merged
@jwnimmer-tri jwnimmer-tri changed the title [Bazel] Update BUILD files for test-declaration consistency Update BUILD files for test-declaration consistency Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwnimmer-tri jwnimmer-tri

Labels
configuration: bazel priority: high type: cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move foo/test/BUILD content into foo/BUILD jwnimmer-tri/drake
1 participant
@jwnimmer-tri