-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move foo/test/BUILD content into foo/BUILD #4459
Move foo/test/BUILD content into foo/BUILD #4459
Conversation
What is the motivation behind moving the contents of Review status: 0 of 33 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
The motivation is that Bazel is slightly more convenient to work with when the library rules and test rules are in the same BUILD file. The #4455 topology is about what |
Cool. Thanks! |
* Paste the foo/test/BUILD content at the end of foo/BUILD * Replace DEPS shared varibale with copy-pasting into uses * Add test/ prefix to paths as needed * Use local ":libname" paths instead of "//full/paths" where possible * Buildifier reformatting
95a270e
to
d9d85f4
Compare
@drake-jenkins-bot linux-gcc-bazel-experimental please |
Review status: 0 of 33 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 33 of 33 files at r1. Comments from Reviewable |
+@david-german-tri do you want to weigh in on this (at a high level, at least)? Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Only to gripe that #2182 was a suboptimal decision, and this illustrates why: we now have a mismatch between our test target paths in Bazel and the paths to the source code on the filesystem. It's not worth revisiting, though. I've confirmed locally that the list of tests is unchanged. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
I'm going to go ahead and merge this so that I can proceed with #4462. Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
This is intended to be shuffle-only changes, without any novel code:
Closes #4457.
This change is