Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lcmtypes] Add benchmark #22480

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[lcmtypes] Add benchmark #22480

wants to merge 1 commit into from

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 17, 2025 •
edited
Loading

Towards #20761 and therefore towards #17231 and #21868.

The objective here is to have sufficient benchmark coverage that we feel confident switching over the implementation.

Sample output:

----------------------------------------------------------------------------------
Benchmark                              Time             CPU    Allocs   Iterations
----------------------------------------------------------------------------------
LcmFixture/ImageArrayEncode         82.9 us         82.9 us     1.375         7994
LcmFixture/ImageArrayDecode         80.1 us         80.1 us    3.4375         8633
LcmFixture/PandaCommandEncode       29.6 ns         29.6 ns      1.25     24645732
LcmFixture/PandaCommandDecode       3.28 ns         3.28 ns    0.3125    216860095
LcmFixture/PandaStatusEncode        71.0 ns         71.0 ns     1.625      9747702
LcmFixture/PandaStatusDecode        3.12 ns         3.12 ns    0.6875    224399289
LcmFixture/ViewerDrawEncode         4.84 us         4.84 us   95.3125       144837
LcmFixture/ViewerDrawDecode         3.12 ns         3.12 ns    94.375    224434971

This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low release notes: none This pull request should not be mentioned in the release notes labels Jan 17, 2025
@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri this seems like it might be up your alley for feature review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sammy-tri sammy-tri

Labels
priority: low release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnimmer-tri @sammy-tri