Remove use of testUtil.h from polynomial_test #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sammy-tri for feature review, please. |
jwnimmer-tri
force-pushed
the
polynomial_test-no-valuecheck
branch
from
f747807 to
37f8fd7
Compare
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
@ggould-tri for platform review and merge (tomorrow). |
|
Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of
util/testUtil.hfromcommon/test/polynomial_test.cc. We should not letcommondepend onutil; the lack of #1987 bites us again. We also have to fixCompareMatricesbut that will be a separate PR.This change is