In from_source, recommend Xenial #5695

jwnimmer-tri · 2017-04-01T19:50:01Z

... as well as other related tune-ups in preparation for recommending Bazel.

This change is

jwnimmer-tri · 2017-04-01T19:50:58Z

+@RussTedrake for feature review, please.

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

liangfok · 2017-04-02T03:37:17Z

+@liangfok

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

drake/doc/from_binary.rst, line 18 at r1 (raw file):

In the meantime, we suggest you :ref:`build from source <build_from_source>`
instead.

BTW, three extra spaces.

drake/doc/models.rst, line 4 at r1 (raw file):

*************************
Geometric Models in Drake

BTW: @Lucy-tri FYI.

Comments from Reviewable

RussTedrake · 2017-04-02T11:55:58Z

Reviewed 6 of 7 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

drake/doc/from_binary.rst, line 14 at r1 (raw file):

We are actively working on a binary release of the new software, but are not
quite finished.  See https://github.com/RobotLocomotion/drake/issues/1766 for
details.

BTW, thanks for updating this, too.

drake/doc/ubuntu_trusty.rst, line 67 at r1 (raw file):

Bazel is required.  Install Bazel using the instructions at
https://bazel.build/versions/master/docs/install-ubuntu.html.

This is more painful than the other build instructions on this page. Can we not just summarize it with sudo apt-get install bazel or something similar (if we need to peg the revision)?

I personally know that when I'm installing a new machine (just did 4 ubuntu VMs on four different laptops this week), I just want to cut and paste the sudo's after I've verified for myself the first time.

Comments from Reviewable

RussTedrake · 2017-04-02T11:56:26Z

btw, i did build the docs to verify locally. looks great apart from my one request below.

Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

RussTedrake · 2017-04-02T12:11:15Z

also, can you recommend which is preferred: xenial vs trusty.

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

jwnimmer-tri · 2017-04-02T12:15:27Z

Personally, I hope we drop Trusty before the year is out -- I think new users should be starting from Xenial. However, I didn't want to update the docs to dissuade people from Trusty until we get more consensus on #5012. If you agree that Xenial should at least be preferred, I'll update this PR with that also.

Comments from Reviewable

jwnimmer-tri · 2017-04-02T12:46:21Z

I pushed some language preferring Xenial.

Review status: 3 of 8 files reviewed at latest revision, 3 unresolved discussions.

a discussion (no related file):
Can someone please re-test locally that the Trusty setup instructions work correctly, and then post back to this discussion? Thanks!

drake/doc/from_binary.rst, line 18 at r1 (raw file):

Previously, liangfok (Chien-Liang Fok) wrote…

BTW, three extra spaces.

Done.

drake/doc/ubuntu_trusty.rst, line 67 at r1 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

This is more painful than the other build instructions on this page. Can we not just summarize it with sudo apt-get install bazel or something similar (if we need to peg the revision)?

I personally know that when I'm installing a new machine (just did 4 ubuntu VMs on four different laptops this week), I just want to cut and paste the sudo's after I've verified for myself the first time.

Done.

Comments from Reviewable

RussTedrake · 2017-04-02T12:49:27Z

Review status: 3 of 8 files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Can someone please re-test locally that the Trusty setup instructions work correctly, and then post back to this discussion? Thanks!

agreed. thanks. i think that if most of the developers are using xenial, then it makes sense to document that fact.

Comments from Reviewable

liangfok · 2017-04-02T13:05:37Z

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

RussTedrake · 2017-04-02T16:31:46Z

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

liangfok · 2017-04-02T19:26:37Z

I will test this on Trusty and post results.

liangfok · 2017-04-02T21:49:15Z

Review status: all files reviewed at latest revision, 2 unresolved discussions.

drake/doc/ubuntu_trusty.rst, line 76 at r2 (raw file):

    echo "0cd6592ac2c5548d566fa9f874a386737e76029f5aabe1f04f8320173a05280d  bazel_0.4.3-linux-x86_64.deb" > bazel_0.4.3-linux-x86_64.deb.sha256
    sha256sum --check bazel_0.4.3-linux-x86_64.deb.sha256 && sudo dpkg -i bazel_0.4.3-linux-x86_64.deb

On my trusty machine, I have Bazel 0.4.4 installed:

$ dpkg -l | grep bazel
ii  bazel                                                 0.4.4                                               amd64        Bazel is a tool that automates software builds and tests.

These instructions are for Bazel 0.4.3. Is this correct?

Comments from Reviewable

jwnimmer-tri · 2017-04-02T22:09:18Z

drake/doc/ubuntu_trusty.rst, line 76 at r2 (raw file):

Previously, liangfok (Chien-Liang Fok) wrote…

On my trusty machine, I have Bazel 0.4.4 installed:
$ dpkg -l | grep bazel
ii  bazel                                                 0.4.4                                               amd64        Bazel is a tool that automates software builds and tests.
These instructions are for Bazel 0.4.3. Is this correct?

Yes, the instructions are for Bazel 0.4.3.

Comments from Reviewable

RussTedrake · 2017-04-03T00:02:01Z

Reviewed 1 of 5 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

drake/doc/from_source.rst, line 81 at r2 (raw file):

first choice if you intend to stay up-to-date with the latest changes,
contribute new features, or experiment directly with Drake.  It is also the
least complex choice to get started.

I guess this is not the entire story. We should add a note here saying that they might still have to use make or ninja if they want to build director.

Comments from Reviewable

jwnimmer-tri · 2017-04-03T01:37:37Z

Review status: 6 of 7 files reviewed at latest revision, 3 unresolved discussions.

drake/doc/from_source.rst, line 81 at r2 (raw file):

Previously, RussTedrake (Russ Tedrake) wrote…

I guess this is not the entire story. We should add a note here saying that they might still have to use make or ninja if they want to build director.

Done.

This discussion pointed out that we shouldn't be putting Bazel atop the list until #5621 is resolved. I've removed this one patch from this PR and set it aside for later.

So for now, the only change to this file is to recommend Xenial.

Comments from Reviewable

RussTedrake · 2017-04-03T01:44:25Z

Review status: 6 of 7 files reviewed at latest revision, 3 unresolved discussions.

drake/doc/from_source.rst, line 81 at r2 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Done.

This discussion pointed out that we shouldn't be putting Bazel atop the list until #5621 is resolved. I've removed this one patch from this PR and set it aside for later.

So for now, the only change to this file is to recommend Xenial.

Sigh. OK.

Comments from Reviewable

liangfok · 2017-04-03T03:28:49Z

Review status: 6 of 7 files reviewed at latest revision, all discussions resolved.

drake/doc/ubuntu_trusty.rst, line 76 at r2 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Yes, the instructions are for Bazel 0.4.3.

I confirm that the above recipe works on an Ubuntu Trusty machine. Below are some stats from my test-machine, which has 16 GB of RAM but an older Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz. It took 1.8 hours to build.

$ bazel build ...
Extracting Bazel installation...
..........
WARNING: /home/liang/dev/drake-distro-5/drake/util/BUILD:63:1: target '//drake/util:app_util' is deprecated: Please use gflags instead of drakeAppUtil.h.
WARNING: /home/liang/.cache/bazel/_bazel_liang/c879694f3a73605ddca427b79a105bfa/external/drake_visualizer/BUILD:2:48: soft_failure.bzl: @drake_visualizer//:drake-visualizer does not work because /home/liang/dev/drake-distro-5/build/install/bin/drake-visualizer was missing.
INFO: Found 2333 targets...
INFO: From Executing genrule //drake/automotive:speed_bump_genrule:
[2017-04-02 23:00:47.833] [console] [info] Loading road geometry.
[2017-04-02 23:00:47.834] [console] [info] Generating OBJ.
INFO: Elapsed time: 6593.061s, Critical Path: 3153.29s

Comments from Reviewable

liangfok · 2017-04-03T03:32:43Z

Reviewed 1 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

jwnimmer-tri assigned RussTedrake Apr 1, 2017

jwnimmer-tri changed the title ~~In from_source, recomment Bazel~~ In from_source, recommend Bazel Apr 1, 2017

liangfok self-assigned this Apr 2, 2017

jwnimmer-tri force-pushed the bazel-doc-preferred branch from 65318e1 to 8189bc9 Compare April 2, 2017 12:43

jwnimmer-tri force-pushed the bazel-doc-preferred branch from 8189bc9 to 31bd2ab Compare April 2, 2017 12:46

jwnimmer-tri added 8 commits April 2, 2017 21:33

Fix indentation error

d1e0732

Rename confusing title

40b4e08

Remove "2.0" scare-word

9a29533

Document that binary releases are deprecated

5a37ad6

Add Bazel as required in the Trusty setup

231aaa1

Add Bazel as required in the OSX setup

1add3b7

Freshen the support matrix text wrt Bazel

c7348fa

Recommend Xenial

d2df567

jwnimmer-tri force-pushed the bazel-doc-preferred branch from 31bd2ab to d2df567 Compare April 3, 2017 01:33

jwnimmer-tri changed the title ~~In from_source, recommend Bazel~~ In from_source, recommend Xenial Apr 3, 2017

jwnimmer-tri merged commit 117d54c into RobotLocomotion:master Apr 3, 2017

jwnimmer-tri deleted the bazel-doc-preferred branch April 3, 2017 13:12

jwnimmer-tri mentioned this pull request Jun 16, 2017

Recommend Bazel during from_source #6366

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In from_source, recommend Xenial #5695

In from_source, recommend Xenial #5695

jwnimmer-tri commented Apr 1, 2017 •

edited

Loading

jwnimmer-tri commented Apr 1, 2017

liangfok commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

jwnimmer-tri commented Apr 2, 2017

jwnimmer-tri commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

liangfok commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

liangfok commented Apr 2, 2017

liangfok commented Apr 2, 2017

jwnimmer-tri commented Apr 2, 2017

RussTedrake commented Apr 3, 2017

jwnimmer-tri commented Apr 3, 2017

RussTedrake commented Apr 3, 2017

liangfok commented Apr 3, 2017

liangfok commented Apr 3, 2017

In from_source, recommend Xenial #5695

In from_source, recommend Xenial #5695

Conversation

jwnimmer-tri commented Apr 1, 2017 • edited Loading

jwnimmer-tri commented Apr 1, 2017

liangfok commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

jwnimmer-tri commented Apr 2, 2017

jwnimmer-tri commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

liangfok commented Apr 2, 2017

RussTedrake commented Apr 2, 2017

liangfok commented Apr 2, 2017

liangfok commented Apr 2, 2017

jwnimmer-tri commented Apr 2, 2017

RussTedrake commented Apr 3, 2017

jwnimmer-tri commented Apr 3, 2017

RussTedrake commented Apr 3, 2017

liangfok commented Apr 3, 2017

liangfok commented Apr 3, 2017

jwnimmer-tri commented Apr 1, 2017 •

edited

Loading