Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let drake_visualizer work outside sandbox on Mac #6391

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Let drake_visualizer work outside sandbox on Mac #6391

merged 1 commit into from
Jun 21, 2017

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Jun 20, 2017

See also #5621 (comment).


This change is Reviewable

@patmarion
Copy link
Member

minor comment---some people might use commands like drake-visualizer --script relative/path/to/script.py which doesn't work if the launcher changes the current working directory.

@jamiesnape
Copy link
Contributor Author

Indeed. Not a workflow we support on Linux either at the moment.

@sammy-tri
Copy link
Contributor

I think this workflow may actually be encouraged in drake/multibody/rigid_body_plant/visualization/README (which uses relative paths to scripts)

@jamiesnape
Copy link
Contributor Author

Yes, that would need to be modified for the current setup. This PR is just syncing up with the Linux behavior for now to meet a request by @RussTedrake in #5621. I am sure we can iterate on these scripts to support the workflow eventually.

@jamiesnape
Copy link
Contributor Author

jamiesnape commented Jun 20, 2017

+@jwnimmer-tri for feature platform review.

@jwnimmer-tri
Copy link
Collaborator

:lgtm: platform review.

We should find someone with native OSX to test this as feature review, perhaps +@soonho-tri?


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@soonho-tri
Copy link
Member

We should find someone with native OSX to test this as feature review, perhaps +@soonho-tri?

I'll do that today.

@soonho-tri
Copy link
Member

:lgtm:

It works for me.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@soonho-tri soonho-tri merged commit a5f1132 into RobotLocomotion:master Jun 21, 2017
@jamiesnape jamiesnape deleted the drake-visualizer-mac branch June 22, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants