Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manipulation from CMake build #6469

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Remove manipulation from CMake build #6469

merged 1 commit into from
Jun 29, 2017

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Jun 29, 2017 •
edited
Loading

Toward #3129.

This change is Reviewable

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for feature review.

@jamiesnape jamiesnape mentioned this pull request Jun 29, 2017
Closed
@jwnimmer-tri
Copy link
Collaborator

:lgtm: platform but let's do +@sammy-tri for feature review, please.

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@sammy-tri
Copy link
Contributor

I guess with #6441 merged we might as well go ahead here. :lgtm:

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jamiesnape jamiesnape merged commit 499f5dd into RobotLocomotion:master Jun 29, 2017
@jamiesnape jamiesnape deleted the cmake-remove-manipulation branch June 29, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sammy-tri sammy-tri

@jwnimmer-tri jwnimmer-tri

Labels
configuration: cmake unused team: kitware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamiesnape @jwnimmer-tri @sammy-tri