Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ccd, octomap, fcl, ignition_* from CMake build #6471

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Remove ccd, octomap, fcl, ignition_* from CMake build #6471

merged 1 commit into from
Jun 30, 2017

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Jun 29, 2017

Toward #3129.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for feature review.

@jwnimmer-tri
Copy link
Collaborator

a discussion (no related file):
People are still using cpplint_wrapper.py; is there a sensible way to keep it?


Comments from Reviewable

@jamiesnape
Copy link
Contributor Author

Review status: 0 of 15 files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

People are still using cpplint_wrapper.py; is there a sensible way to keep it?

I can just roll back that part, though I would strongly advise them not to use it.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

a discussion (no related file):

Previously, jamiesnape (Jamie Snape) wrote…

I can just roll back that part, though I would strongly advise them not to use it.

Yeah, I think we can pivot away from it pretty quickly and then remove it, but we need to flesh out a little more glue and docs first.


Comments from Reviewable

@jamiesnape jamiesnape changed the title Remove ccd, google_styleguide, octomap, fcl, ignition_* from CMake build Remove ccd, octomap, fcl, ignition_* from CMake build Jun 29, 2017
@jwnimmer-tri
Copy link
Collaborator

:lgtm:

+@soonho-tri for platform review, please.


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@soonho-tri
Copy link
Member

:lgtm:


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@soonho-tri soonho-tri merged commit a11ddaf into RobotLocomotion:master Jun 30, 2017
@jamiesnape jamiesnape deleted the cmake-remove-more-externals branch June 30, 2017 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants