Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vtk from CMake build #6476

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Remove vtk from CMake build #6476

merged 1 commit into from
Jun 30, 2017

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Jun 29, 2017

Toward #3129.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for feature review.

@jwnimmer-tri
Copy link
Collaborator

:lgtm: +@soonho-tri for platform review, please.


Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@soonho-tri
Copy link
Member

:lgtm:

BTW, a related issue: When this PR gets merged, can we update http://drake.mit.edu/mac.html to remove pyqt@4, qwt-qt4, and vtk5? My understanding is that we have them for a CMake build. They cause problems when we use bazel and have to remove them to make it work.


Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@soonho-tri
Copy link
Member

pyqt@4

OK. We don't have this one anymore at least.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@jamiesnape
Copy link
Contributor Author

Still needed for Director for the moment, though that will change in the next few days.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@soonho-tri
Copy link
Member

I see. Thanks!


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

1 similar comment
@soonho-tri
Copy link
Member

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@soonho-tri
Copy link
Member

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@soonho-tri soonho-tri merged commit 41d162c into RobotLocomotion:master Jun 30, 2017
@jamiesnape jamiesnape deleted the cmake-remove-vtk branch June 30, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants